Ticket #1074: #1074.2.patch

addons/payment-paypal.php

@@ -726 +726 @@
         }
 
         /**
+         * Checks if a transaction is refundable
+         * 
+         * @global type $camptix
+         * @param type $payment_token
+         * @return boolean
+         */
+        function transaction_is_refundable( $payment_token ){
+                /** @var $camptix CampTix_Plugin */
+                global $camptix;
+
+                $refund_expiry = 60; // no. of days
+
+                if ( empty( $refund_expiry ) )
+                        return true;
+
+                $txn_details = $camptix->get_post_meta_from_payment_token( $payment_token, 'tix_transaction_details' );
+
+                // more than 60 days since transaction
+                if( strtotime( $txn_details['raw']['TIMESTAMP'] + $refund_expiry * DAY_IN_SECONDS ) < time() )
+                        return new WP_Error('refund-expired', sprintf( __( 'PayPal error: PayPal only allows refund within %d days.', 'camptix' ), $refund_expiry ) );
+
+                return true; // return true by default
+
+        }
+
+        /**
          * Submits a single, user-initiated refund request to PayPal and returns the result
          *
          * @param string $payment_token
@@ -733 +759 @@
          * @return int One of the CampTix_Plugin::PAYMENT_STATUS_{status} constants
          */
         function payment_refund( $payment_token ) {
+
+                // check if this is within PayPal's 60 day refund period
+                $is_refundable = $this->transaction_is_refundable( $payment_token );
+
+                if( is_wp_error( $is_refundable ) )
+                        return $is_refundable;
+
                 /** @var $camptix CampTix_Plugin */
                 global $camptix;
 

camptix.php

@@ -5852 +5852 @@
 
                                 // Attempt to process the refund transaction
                                 $result = $payment_method_obj->payment_refund( $transaction['payment_token'] );
-                                $this->log( 'Individual refund request result.', $attendee->ID, $result, 'refund' );
-                                if ( CampTix_Plugin::PAYMENT_STATUS_REFUNDED == $result ) {
+
+                                if ( CampTix_Plugin::PAYMENT_STATUS_REFUNDED === $result ) {
                                         foreach ( $attendees as $attendee ) {
                                                 update_post_meta( $attendee->ID, 'tix_refund_reason', $reason );
                                                 $this->log( 'Refund reason attached with data.', $attendee->ID, $reason, 'refund' );
                                         }
 
+                                        $this->log( 'Individual refund request result.', $attendee->ID, $result, 'refund' );
                                         $this->info( __( 'Your tickets have been successfully refunded.', 'camptix' ) );
+
                                         return $this->form_refund_success();
+
+                                } elseif ( is_wp_error( $result )){
+
+                                        $err_msg = $result->get_error_message();
+                                        $this->log( 'Individual refund request result.', $attendee->ID, $err_msg, 'refund' );
+                                        $this->error( $err_msg );
                                 } else {
+                                        $this->log( 'Individual refund request result.', $attendee->ID, $result, 'refund' );
                                         $this->error( __( 'Can not refund the transaction at this time. Please try again later.', 'camptix' ) );
                                 }
+
                         }
                 }