Ticket #4053: 4053.2.diff

common/includes/slack/announce/config.php

@@ -297 +297 @@
 
 function get_committers() {
         return array(
-                'dd32', 'nacin', 'helen', 'azaozz', 'westi',
+                'matt', 'dd32', 'nacin', 'helen', 'azaozz', 'westi',
                 'ocean90', 'wonderboymusic', 'johnbillion',
-                'jorbin', 'jeremyfelt', 'pento', 'obenland', 'iseulde',
+                'jorbin', 'jeremyfelt', 'pento', 'obenland',
                 'westonruter', 'afercia', 'karmatosed', 'rmccue', 'michaelarestad',
                 'swissspidy', 'rachelbaker', 'joehoyle', 'melchoyce',
                 'peterwilsoncc', 'joemcgill', 'davidakennedy', 'adamsilverstein',
-                'flixos90', 'iandunn', 'kadamwhite',
+                'flixos90', 'iandunn', 'kadamwhite', 'jrf', 'atimmer', 'laurelfulford',
+                'allendav', 'omarreiss', 'allancole', 'lonelyvegan', 'antpb', 'mcsf',
+                'herregroen', 'youknowriad', 'gziolo', 'aduth', 'jorgefilipecosta',
+                'bpayton', 'noisysocks', 'desrosj', 'tellyworth',
 
                 'markjaquith',    // @mark on Slack
                 'nbachiyski',     // @nb on Slack
@@ -314 +317 @@
                 'mikeschroder',   // @mike on Slack
                 'jnylen0',        // @jnylen on Slack
                 'matveb',         // @matias on Slack
+                'iseulde',        // @ella on Slack
+                'johnjamesjacoby' // @JJJ on Slack
         );
 }
 

common/includes/slack/announce/lib.php

@@ -83 +83 @@
                 return;
         }
 
-        if ( $data['command'] === '/committers' ) {
-                // This command seems to not be used actively, in preference for the slack @committers group pings.
-                $committers = get_committers();
-                if ( ! in_array( $user, $committers, true ) ) {
-                        return;
-                }
-
-                // TODO: Note that pinging users by `@username` is deprecated, and we now have WordPress.org usernames in the above list.
-                // This should be upadted to ping users by the `<@U.....>` format.
-
-                $text = sprintf( "*@committers:* %s\n_(cc: %s)_", $data['text'], '@' . implode( ', @', $committers ) );
-        } elseif ( $data['command'] === '/deputies' ) {
+        if ( $data['command'] === '/deputies' ) {
                 $pingable_deputies = get_pingable_wordcamp_deputies();
 
                 if ( ! in_array( $user, $pingable_deputies, true ) ) {

trac.wordpress.org/templates/core/site-specific.html

@@ -65 +65 @@
         mcsf: 'Core Committer',
         herregroen: 'Core Committer',
         atimmer: 'Core Committer',
+        youknowriad: 'Core Committer',
+        gziolo: 'Core Committer',
+        jorgefilipecosta: 'Core Committer',
+        aduth: 'Core Committer',
+        bpayton: 'Core Committer',
+        noisysocks: 'Core Committer',
+        desrosj: 'Core Committer',
         johnjamesjacoby: 'Core Committer',
         tellyworth: 'Core Committer',
-
         iammattthomas: 'Core Committer',
         lancewillett: 'Themes Committer',
         iandstewart: 'Themes Committer',