Ticket #5357: red-flag-many-plugins-fast.diff

trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-review-tools.php

@@ -208 +208 @@
                                 }
                         }
 
-                        // User account was registered less than 2 weeks ago (but longer than 3 days) (user is still fairly new).
-                        $two_weeks_ago  = time() - ( 2 * WEEK_IN_SECONDS );
-                        $three_days_ago = time() - ( 3 * DAY_IN_SECONDS );
-                        if ( strtotime( $author->user_registered ) > $two_weeks_ago && strtotime( $author->user_registered ) < $three_days_ago ) {
+                        // There has been an uptick in users with names ending in numbers AND being very new, submitting
+                        // a lot of plugins after being banned.
+                        $two_weeks_ago = time() - ( 2 * WEEK_IN_SECONDS );
+                        $four_days_ago = time() - ( 4 * DAY_IN_SECONDS );
+                        if ( is_numeric( substr( $author->user_login, - 1, 1 ) ) && strtotime( $author->user_registered ) > $four_days_ago ) {
+                                // Username ends in numbers and is less than 4 days old.
+                                array_push( self::$flagged['high'], 'account registered less than 4 days ago and username ends in numbers' );
+                        } elseif ( is_numeric( substr( $author->user_login, - 1, 1 ) ) ) {
+                                // Username just ends in numbers.
+                                array_push( self::$flagged['med'], 'username ends in numbers' );
+                        } elseif ( strtotime( $author->user_registered ) > $two_weeks_ago && strtotime( $author->user_registered ) < $four_days_ago ) {
+                                // User account was registered less than 2 weeks ago (but longer than 4 days).
                                 array_push( self::$flagged['low'], 'account registered less than 2 weeks ago' );
+                                // If they have 4+ plugins in 2 weeks, it MAY be an issue.
+                                if ( 4 <= count( $author_plugins ) ) {
+                                        array_push( self::$flagged['med'], 'high number of submitted plugins in a short timeframe' );
+                                }
+                        } elseif ( strtotime( $author->user_registered ) > $four_days_ago ) {
+                                // User account was registered less than 3 days ago.
+                                array_push( self::$flagged['med'], 'account registered less than 4 days ago' );
+                                // If they have 2+ plugins in 4 days, it's a problem.
+                                if ( 2 <= count( $author_plugins ) ) {
+                                        array_push( self::$flagged['high'], 'high number of submitted plugins in a short timeframe' );
+                                }
                         }
-                        if ( strtotime( $author->user_registered ) > $three_days_ago ) {
-                                array_push( self::$flagged['low'], 'account registered less than 3 days ago' );
-                        }
 
-                        // Username ends in numbers.
-                        if ( is_numeric( substr( $author->user_login, - 1, 1 ) ) ) {
-                                array_push( self::$flagged['low'], 'username ends in numbers' );
-                        }
-
                         // User has no URL.
                         if ( empty( $author->user_url ) ) {
                                 array_push( self::$flagged['low'], 'account has no URL' );