Ticket #6256: patch.6256.3.diff

wp-content/plugins/wporg-gp-customizations/inc/class-plugin.php

@@ -55 +55 @@
 
                 add_filter( 'gp_for_translation_clauses', array( $this, 'allow_searching_for_no_author_translations' ), 10, 3 );
 
+                add_filter( 'gp_warning_discarded', array( $this, 'disable_discarding_some_warnings' ), 10, 5 );
+
                 // Cron.
                 add_filter( 'cron_schedules', [ $this, 'register_cron_schedules' ] );
                 add_action( 'init', [ $this, 'register_cron_events' ] );
@@ -325 +327 @@
         }
 
         /**
+         * Allow disabling some warnings.
+         *
+         * See https://meta.trac.wordpress.org/ticket/6256
+         */
+        function disable_discarding_some_warnings( $project_id, $translation_set_id, $translation_id, $warning, $user ) {
+                if ( 'unexpected_sprintf_token' === $warning ) {
+                        GP::$current_route->die_with_error( __( 'This warning cannot be discarded. Please remove the unexpected placeholders. A % needs to be translated as %%.', 'wporg' ) );
+                }
+
+                if ( 'placeholders' === $warning ) {
+                        // Since we only get the warning key, we need to determine the exact warning to decide if we should prevent it.
+                        function _placeholders_counts( $string, $re ) {
+                                $counts = array();
+                                preg_match_all( "/$re/", $string, $matches );
+                                foreach ( $matches[0] as $match ) {
+                                        $counts[ $match ] = gp_array_get( $counts, $match, 0 ) + 1;
+                                }
+
+                                return $counts;
+                        }
+
+                        $placeholders_re = apply_filters( 'gp_warning_placeholders_re', '(?<!%)%(\d+\$(?:\d+)?)?(\.\d+)?[bcdefgosuxEFGX%l@]' );
+                        $translation = GP::$translation->get( $translation_id );
+                        $original = GP::$original->get( $translation->original_id );
+                        foreach ( $translation->translations() as $k => $t ) {
+                                $original_counts    = _placeholders_counts( $k === 0 ? $original->singular : $original->plural, $placeholders_re );
+                                $translation_counts = _placeholders_counts( $t, $placeholders_re );
+                                $all_placeholders   = array_unique( array_merge( array_keys( $original_counts ), array_keys( $translation_counts ) ) );
+                                foreach ( $all_placeholders as $placeholder ) {
+                                        $original_count    = gp_array_get( $original_counts, $placeholder, 0 );
+                                        $translation_count = gp_array_get( $translation_counts, $placeholder, 0 );
+                                        if ( $original_count < $translation_count ) {
+                                                if ( '%%' === $placeholder ) {
+                                                        // Extra %% is ok.
+                                                        continue;
+                                                }
+                                                GP::$current_route->die_with_error( __( 'This warning cannot be discarded. Please remove the extra placeholders.', 'wporg' ) );
+                                        }
+                                }
+                        }
+                }
+        }
+
+        /**
          * Adds a link to view originals in consistency tool.
          *
          * @param array              $more_links      The links to be output.