Ticket #7217: 7217.diff

zip/class-serve.php

@@ -46 +46 @@
                 } elseif ( preg_match( '!^/plugin-checksums/(?P<slug>[a-z0-9-_]+)/(?P<version>.+?)(\.json)?$!i', $path, $m ) ) {
                         // Checksums
                         $checksum_request  = true;
                         $signature_request = false;
                 } else {
                         throw new Exception( __METHOD__ . ': Invalid URL.' );
                 }
 
                 $slug = strtolower( $m['slug'] );
 
                 $version = 'trunk';
                 if ( isset( $m['version'] ) && '' !== $m['version'] ) {
                         $version = $m['version'];
                 }
 
+                // Check to see if the plugin is closed.
+                if ( ! $checksum_request ) {
+                        $closed_date = $this->get_post_meta( $slug, 'plugin_closed_date' );
+                        if ( $closed_date && strtotime( $closed_date ) + 5184000 /* 60 days */ < time() ) {
+                                throw new Exception( __METHOD__ . ': Plugin is closed.' );
+                        }
+                }
+
                 // If the latest-stable is requested, determine the file to serve.
                 $is_latest_stable = ( 'latest-stable' == $version );
                 if ( $is_latest_stable ) {
-                        $version = $this->get_stable_tag( $slug );
+                        $version = $this->get_post_meta( $slug, 'stable_tag' );
+                        if ( ! $version ) {
+                                throw new Exception( __METHOD__ . ': No stable version found.' );
+                        }
                 }
 
                 // Checksum requests for 'trunk' are not possible.
                 if ( $checksum_request && 'trunk' == $version ) {
                         throw new Exception( __METHOD__ . ': Checksum requests must include a version.' );
                 }
 
                 $args = array(
                         'stats' => true,
                 );
 
                 if ( $checksum_request || $signature_request ) {
                         $args['stats'] = false;
 
                 } elseif ( isset( $_GET['stats'] ) ) {
                         $args['stats'] = (bool) $_GET['stats'];
 
                 } elseif ( isset( $_GET['nostats'] ) ) {
                         $args['stats'] = ! empty( $_GET['nostats'] );
                 }
 
-
                 return compact( 'zip', 'slug', 'version', 'args', 'checksum_request', 'signature_request', 'is_latest_stable' );
         }
 
         /**
          * Redirect to the latest stable version if requested.
          *
          * @param array $request The request array for the request.
          */
         protected function maybe_redirect_latest_stable( $request ) {
                 if ( ! $request['is_latest_stable'] ) {
                         return;
                 }
 
                 $file     = $this->get_file( $request );
                 $redirect = 'https://downloads.wordpress.org/plugin/' . basename( $file );
@@ -107 +117 @@
                 // CORS, to match the ZIP passthrough.
                 header( 'Access-Control-Allow-Methods: GET, HEAD' );
                 header( 'Access-Control-Allow-Origin: *' );
 
                 // Tell browsers to only cache this for 5 minutes.
                 header( 'Cache-Control: max-age=300' );
 
                 // Redirect to the file they want.
                 header( 'Location: ' . $redirect, 302 );
                 exit;
         }
 
         /**
          * Retrieve the stable_tag for a given plugin from Cache or the Database.
          *
-         * @param string $plugin_slug The plugin slug
-         * @return string The stable_tag on success, Exception thrown on failure.
+         * @param string $plugin_slug The plugin slug.
+         * @param string $meta_key    The meta_key to retrieve.
+         * @return string The meta_value on success, Exception thrown on failure.
          */
-        protected function get_stable_tag( $plugin_slug ) {
+        protected function get_post_meta( $plugin_slug, $meta_key ) {
                 global $wpdb;
 
+                $value   = false;
                 $post_id = $this->get_post_id( $plugin_slug );
 
-                // Determine the stable_tag
-                $meta = wp_cache_get( $post_id, 'post_meta' );
+                // Determine the value from the object cache first.
+                $meta     = wp_cache_get( $post_id, 'post_meta' );
+                $in_cache = isset( $meta[ $meta_key ][0] );
 
-                $version = false;
-                if ( isset( $meta['stable_tag'][0] ) ) {
-                        $version = $meta['stable_tag'][0];
-                }
-                if ( ! $version ) {
-                        $version = $wpdb->get_var( $wpdb->prepare( "SELECT meta_value FROM $wpdb->postmeta WHERE post_id = %d AND meta_key = 'stable_tag' LIMIT 1", $post_id ) );
-                }
-                if ( ! $version ) {
-                        throw new Exception( __METHOD__ . ": A version for $plugin_slug cannot be determined." );
+                if ( $in_cache ) {
+                        $value = $meta[ $meta_key ][0];
+                } else {
+                        // Check our specific cache groups.
+                        $value = wp_cache_get( $post_id, 'plugin-meta-' . $meta_key, false, $found );
+
+                        if ( ! $found ) {
+                                $value = $wpdb->get_var( $wpdb->prepare(
+                                        "SELECT meta_value FROM $wpdb->postmeta WHERE post_id = %d AND meta_key = %s LIMIT 1",
+                                        $post_id,
+                                        $meta_key
+                                ) );
+
+                                wp_cache_set( $post_id, $value, 'plugin-meta-' . $meta_key, 300 /* 5 mins */ );
+                        }
                 }
 
-                return $version;
+                return $value;
         }
 
         /**
          * Retrieve the post_id for a Plugin slug.
          *
          * This function uses the Object Cache and $wpdb directly to avoid
          * a dependency upon WordPress.
          *
          * @param string $plugin_slug The plugin slug.
          * @return int The post_id for the plugin. Exception thrown on failure.
          */
         protected function get_post_id( $plugin_slug ) {
                 global $wpdb;
 
                 $post_id = wp_cache_get( $plugin_slug, 'plugin-slugs' );
                 if ( false === $post_id ) {
-                        $post_id = $wpdb->get_var( $wpdb->prepare( "SELECT ID from $wpdb->posts WHERE post_type = 'plugin' AND post_name = %s", $plugin_slug ) );
+                        $post_id = $wpdb->get_var( $wpdb->prepare(
+                                "SELECT ID FROM $wpdb->posts WHERE post_type = 'plugin' AND post_name = %s LIMIT 1",
+                                $plugin_slug
+                        ) );
+
                         wp_cache_add( $plugin_slug, $post_id, 'plugin-slugs' );
                 }
 
                 if ( ! $post_id ) {
                         throw new Exception( __METHOD__ . ": A post_id for $plugin_slug cannot be determined." );
                 }
 
                 return $post_id;
         }
 
         /**
          * Returns the file to be served for the request.
          *
          * @param array $request The request object for the request.
          * @return array The file to serve.