Changeset 10003 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-block-plugin-checker.php

Timestamp:

07/03/2020 04:10:55 AM (6 years ago)

Author:

tellyworth

Message:

Block directory: initial UI improvements for block validator.

Props ryelle.
See #5303.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-block-plugin-checker.php (modified) (15 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-block-plugin-checker.php

@@ -68 +68 @@
                                 __FUNCTION__,
                                 'error',
-                                sprintf( __( 'Invalid url %s', 'wporg-plugins' ), $url ),
+                                sprintf( __( 'Invalid url: %s', 'wporg-plugins' ), $url ),
                                 $url
                         );
@@ -78 +78 @@
                                 __FUNCTION__,
                                 'error',
-                                sprintf( __( 'URL must be GitHub or plugins.svn.wordpress.org %s', 'wporg-plugins' ), $url ),
+                                sprintf( __( 'URL must be GitHub or plugins.svn.wordpress.org: %s', 'wporg-plugins' ), $url ),
                                 $url
                         );
@@ -90 +90 @@
                                         __FUNCTION__,
                                         'error',
-                                        sprintf( __( 'URL must be a plugin repository %s', 'wporg-plugins' ), $url ),
+                                        sprintf( __( 'URL must be a plugin repository: %s', 'wporg-plugins' ), $url ),
                                         $url
                                 );
@@ -116 +116 @@
                                         __FUNCTION__,
                                         'error',
-                                        sprintf( __( 'URL must be a plugin repository %s', 'wporg-plugins' ), $url ),
+                                        sprintf( __( 'URL must be a plugin repository: %s', 'wporg-plugins' ), $url ),
                                         $url
                                 );
@@ -213 +213 @@
 
         public function find_blocks( $base_dir ) {
+                $blocks = array();
                 $this->block_json_files = Filesystem::list_files( $base_dir, true, '!(?:^|/)block\.json$!i' );
                 if ( false && ! empty( $this->block_json_files ) ) {
@@ -282 +283 @@
                         $this->record_result( __FUNCTION__,
                                 'error',
-                                __( 'Missing readme.txt file', 'wporg-plugins' ),
+                                __( 'Missing readme.txt file.', 'wporg-plugins' ),
                                 $this->relative_filename( $this->readme_path )
                         );
@@ -333 +334 @@
                                         $this->record_result( __FUNCTION__,
                                                 'info',
-                                                sprintf( __( 'Block name already exists in plugin %s', 'wporg-plugins' ), $query->posts[0]->post_name ),
+                                                sprintf( __( 'Block name %s already exists in plugin %s.', 'wporg-plugins' ), $block->name, $query->posts[0]->post_name ),
                                                 [ 'block_name' => $block->name, 'slug' => $post->post_name ]
                                         );
@@ -354 +355 @@
                         $this->record_result( __FUNCTION__,
                                 'info',
-                                sprintf( _n( 'Found %d block', 'Found %d blocks', count( $this->blocks ), 'wporg-plugins' ), count( $this->blocks ) ),
+                                sprintf( _n( 'Found %d block.', 'Found %d blocks.', count( $this->blocks ), 'wporg-plugins' ), count( $this->blocks ) ),
                                 array_keys( $this->blocks )
                         );
@@ -368 +369 @@
                                 $this->record_result( __FUNCTION__,
                                         'info',
-                                        sprintf( __( 'block.json file exists for block %s', 'wporg-plugins' ), $block_name ),
+                                        sprintf( __( 'block.json file exists for block %s.', 'wporg-plugins' ), $block_name ),
                                         $this->block_json_files[ $block_name ]
                                 );
@@ -377 +378 @@
                         $this->record_result( __FUNCTION__,
                                 'warning',
-                                __( 'No block.json files were found', 'wporg-plugins' )
+                                __( 'No block.json files were found.', 'wporg-plugins' )
                         );
                 }
@@ -392 +393 @@
                                 $this->record_result( __FUNCTION__,
                                         'info',
-                                        sprintf( __( 'Scripts found for block %s', 'wporg-plugins' ), $block_name ),
+                                        sprintf( __( 'Scripts found for block %s.', 'wporg-plugins' ), $block_name ),
                                         $block_scripts[ $block_name ]
                                 );
@@ -398 +399 @@
                                 $this->record_result( __FUNCTION__,
                                         'warning',
-                                        sprintf( __( 'No scripts found for block %s', 'wporg-plugins' ), $block_name ),
+                                        sprintf( __( 'No scripts found for block %s.', 'wporg-plugins' ), $block_name ),
                                         $block_name
                                 );
@@ -414 +415 @@
                                         $this->record_result( __FUNCTION__,
                                                 'info',
-                                                sprintf( __( 'Script file exists for block %s', 'wporg-plugins' ), $block_name ),
+                                                sprintf( __( 'Script file exists for block %s.', 'wporg-plugins' ), $block_name ),
                                                 $script
                                         );
@@ -420 +421 @@
                                         $this->record_result( __FUNCTION__,
                                                 'warning',
-                                                sprintf( __( 'Missing script file for block %s', 'wporg-plugins' ), $block_name ),
+                                                sprintf( __( 'Missing script file for block %s.', 'wporg-plugins' ), $block_name ),
                                                 $script
                                         );
@@ -445 +446 @@
                         $this->record_result( __FUNCTION__,
                                 'error',
-                                sprintf( __( 'registerBlockType() must be called in a JavaScript file', 'wporg-plugins' ) )
+                                sprintf( __( '<code>registerBlockType()</code> must be called in a JavaScript file.', 'wporg-plugins' ) )
                         );
                 }