Changeset 10004

Timestamp:

07/03/2020 04:19:48 AM (5 years ago)

Author:

tellyworth

Message:

Plugin directory: validator forms should return, not echo.

The display() method of the shortcode classes should return output. The validator forms were mistakenly outputting it as direct inline HTML.

Added output buffering as a quick solution.

Thanks dd32.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes

Files:

• class-block-validator.php (modified) (2 diffs)
• class-readme-validator.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-block-validator.php

@@ -10 +10 @@
      */
     public static function display() {
+        ob_start();
         $plugin_url = $_REQUEST['plugin_url'] ?? '';
         ?>
@@ -31 +32 @@
         </div>
         <?php
+        return ob_get_clean();
     }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-readme-validator.php

@@ -10 +10 @@
      */
     public static function display() {
+        ob_start();
         ?>
         <div class="wrap">
@@ -50 +51 @@
         </div>
         <?php
+        return ob_get_clean();
     }