Changeset 10040

Timestamp:

07/08/2020 10:54:18 PM (3 years ago)

Author:

ryelle

Message:

Plugin Directory: Add a check for one top-level block.

Multiple blocks are allowed, but there should be only one "main" block. This checks the block.json file for each block (if exists), and flags if there is more than 1 block without a parent property. This also fixes the check_for_blocks check to warn if more than 15 blocks are found.

See #5303

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-block-plugin-checker.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-block-plugin-checker.php

@@ -441 +441 @@
             $this->record_result(
                 __FUNCTION__,
-                'info',
+                // Over 15 blocks is probably too many.
+                count( $this->blocks ) < 15 ? 'info' : 'warning',
                 sprintf(
                     // translators: %d number of blocks.
@@ -501 +502 @@
                 );
             }
+        }
+    }
+
+    /**
+     * Check for a single parent block
+     */
+    function check_for_single_parent() {
+        if ( empty( $this->blocks ) || ! is_array( $this->blocks ) ) {
+            return;
+        }
+
+        $top_level_blocks = array_filter(
+            $this->blocks,
+            function( $block ) {
+                return ! isset( $block->parent ) || is_null( $block->parent );
+            }
+        );
+
+        if ( count( $top_level_blocks ) > 1 ) {
+            $list = array_map(
+                function( $block ) {
+                    return ! empty( $block->title ) ? $block->title : $block->name;
+                },
+                $top_level_blocks
+            );
+            $this->record_result(
+                __FUNCTION__,
+                'warning',
+                sprintf(
+                    /* translators: %s is a list of block names. */
+                    __( 'More than one top level block was found: %s', 'wporg-plugins' ),
+                    implode( ', ', $list )
+                ),
+                $block_name
+            );
         }
     }