Changeset 10050

Timestamp:

07/10/2020 02:46:17 AM (4 years ago)

Author:

dd32

Message:

Plugin Directory: Add some restrictions on the size of asset files to import.

The initial limits are:

• Screenshots: 10MB, very few are larger than this.
• Banners: 4MB (Low & High res)
• Icons: 1MB

See #5171.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

@@ -417 +417 @@
         );
 
+        $asset_limits = array(
+            'screenshot' => 10 * MB_IN_BYTES,
+            'banner'     => 4 * MB_IN_BYTES,
+            'icon'       => 1 * MB_IN_BYTES,
+        );
+
         $svn_assets_folder = SVN::ls( self::PLUGIN_SVN_BASE . "/{$plugin_slug}/assets/", true /* verbose */ );
         if ( $svn_assets_folder ) { // /assets/ may not exist.
@@ -425 +431 @@
                 }
 
+                // Don't import oversize assets.
+                if ( $asset['filesize'] > $asset_limits[ $m['type'] ] ) {
+                    continue;
+                }
+
                 $type       = $m['type'];
                 $filename   = $asset['filename'];
@@ -444 +455 @@
             if ( isset( $assets['screenshot'][ $filename ] ) ) {
                 // Skip it, it exists within /assets/ already
+                continue;
+            }
+
+            // Don't import oversize assets.
+            if ( filesize( $plugin_screenshot ) > $asset_limits['screenshot'] ) {
                 continue;
             }