Changeset 10071

Timestamp:

07/15/2020 09:07:43 PM (5 years ago)

Author:

ryelle

Message:

Plugin Directory: Remove *.asset.php check from block checker

This check only applies to a specific build process, and having more than one asset file is not inherently a bad thing.

See #5303

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• cli/class-block-plugin-checker.php (modified) (1 diff)
• shortcodes/class-block-validator.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-block-plugin-checker.php

@@ -691 +691 @@
 
     /**
-     * Does it have an index.asset.php file generate by the create block scripts?
-     */
-    function check_asset_php_file() {
-        $count = 0;
-        foreach ( $this->asset_php_files as $file ) {
-            $contents = file_get_contents( $file );
-            if ( false !== strpos( $contents, '<?php return array(' ) )
-                ++ $count;
-        }
-
-        if ( 1 === $count ) {
-            $this->record_result(
-                __FUNCTION__,
-                'info',
-                // translators: %s is the name of asset file.
-                sprintf(
-                    __( 'PHP asset file found: %s.', 'wporg-plugins' ),
-                    '<code>' . $this->relative_filename( $file ) . '</code>'
-                ),
-                $this->relative_filename( $file )
-            );
-        } elseif ( $count > 1 ) {
-            $this->record_result(
-                __FUNCTION__,
-                'warning',
-                // translators: %s is the number of asset files.
-                sprintf( __( 'Found %s PHP asset files.', 'wporg-plugins' ), $count ),
-                array_map( null, array( $this->relative_filename( $file ) ), $this->asset_php_files )
-            );
-        }
-    }
-
-    /**
      * Does it have a lot of PHP code?
      */

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-block-validator.php

@@ -267 +267 @@
             case 'check_block_json_is_valid_json':
                 return __( 'This block.json file is invalid. The Block Directory needs to be able to read this file.', 'wporg-plugins' );
-            case 'check_asset_php_file':
-                return __( '', 'wporg-plugins' ); // @todo
             case 'check_php_size':
                 return __( 'Block plugins should keep the PHP code to a mimmum. If you need a lot of PHP code, your plugin probably belongs in the main Plugin Directory rather than the Block Directory.', 'wporg-plugins' );