Changeset 10085

Timestamp:

07/20/2020 08:40:31 AM (3 years ago)

Author:

tellyworth

Message:

Plugin directory: better asset detection in block checker.

This should make the block checker use identical guesswork to the importer when looking for block assets.

See #5303.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-block-plugin-checker.php (modified) (5 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-block-plugin-checker.php

@@ -37 +37 @@
     protected $asset_php_files = null;
     protected $block_json_validation = array();
+    protected $block_assets = array();
+    protected $block_scripts = array();
 
     /**
@@ -233 +235 @@
 
         $this->asset_php_files = $this->find_asset_php_files( $this->path_to_plugin );
+
+        $this->block_assets = $this->find_block_assets( $this->path_to_plugin );
+        $this->block_scripts = $this->find_block_scripts( $this->path_to_plugin );
     }
 
@@ -274 +279 @@
     }
 
-    public function find_block_scripts() {
+    public function find_block_assets( $base_dir ) {
+        $assets = Import::find_possible_block_assets( $base_dir );
+        $assets = array_map( array( $this, 'relative_filename' ), $assets );
+
+        $block_assets = array(
+            'js' => array(),
+            'css' => array(),
+        );
+
+        foreach ( $assets as $file ) {
+            $ext = strtolower( pathinfo( $file, PATHINFO_EXTENSION ) );
+            if ( array_key_exists( $ext, $block_assets ) ) {
+                $block_assets[ $ext ][] = $file;
+            }
+        }
+
+        return $block_assets;
+    }
+
+    public function find_block_scripts( $base_dir ) {
+
         $block_scripts = \array_map(
             function( $block ) {
@@ -283 +308 @@
                     if ( isset( $block->$prop ) ) {
                         $assets[ $prop ] = $block->$prop;
+                    }
+                }
+
+                // If no block.json data was found, try to guess.
+                if ( empty( $assets ) ) {
+                    // If js or css assets were found, assume we can use the first one.
+                    if ( !empty( $this->block_assets[ 'js' ] ) ) {
+                        $assets[ 'script' ] = reset( $this->block_assets[ 'js' ] );
+                    }
+
+                    if ( !empty( $this->block_assets[ 'css' ] ) ) {
+                        $assets[ 'style' ] = reset( $this->block_assets[ 'css' ] );
                     }
                 }
@@ -570 +607 @@
     function check_for_block_script_files() {
         $seen_scripts = array();
-        foreach ( $this->find_block_scripts() as $block_name => $scripts ) {
+        foreach ( $this->block_scripts as $block_name => $scripts ) {
             foreach ( $scripts as $kind => $script ) {
                 // No need to warn multiple times for the same value.