Changeset 10118

Timestamp:

08/05/2020 03:37:07 AM (4 years ago)

Author:

tellyworth

Message:

Plugin directory: check block plugins for multiple namespaces.

See #5303.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• cli/class-block-plugin-checker.php (modified) (1 diff)
• shortcodes/class-block-validator.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-block-plugin-checker.php

@@ -578 +578 @@
                 }
             }
+        }
+    }
+
+    /**
+     * Blocks with different namespaces points to a problem, most likely a suite of blocks.
+     */
+    function check_for_multiple_namespaces() {
+        $namespaces = array();
+        foreach ( $this->blocks as $block ) {
+            if ( $parts = explode( '/', $block->name ) ) {
+                $namespaces[] = $parts[0];
+            }
+        }
+
+        $namespaces = array_unique( $namespaces );
+
+        if ( count( $namespaces ) > 1 ) {
+            $this->record_result(
+                __FUNCTION__,
+                'error',
+                // translators: %s is the block name.
+                sprintf( __( 'Found blocks with %d different namespaces: %s.', 'wporg-plugins' ), count( $namespaces ), '<code>' . implode( ', ', $namespaces ) . '</code>' ),
+                $namespaces
+            );
         }
     }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-block-validator.php

@@ -326 +326 @@
             case 'check_total_size':
                 return __( 'Larger plugins will take longer to install. This is more noticeable in the Block Directory, where the user expects blocks to be added immediately. Try reducing your file size by optimizing images & SVGs, only including the assets you need (images, fonts, etc), and using core-provided JavaScript libraries.', 'wporg-plugins' );
+            case 'check_for_multiple_namespaces':
+                return __( 'Block plugins should contain a single main block. Please ensure there are no extraneous blocks included by mistake.' );
             // This is a special case, since multiple values may be collapsed.
             case 'check_block_json_is_valid':