Changeset 10176

Timestamp:

08/18/2020 05:55:10 AM (5 years ago)

Author:

tellyworth

Message:

Plugin dir: improve block checker handling of json errors.

Links to the json file when displaying an error.

See #5303.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-block-plugin-checker.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-block-plugin-checker.php

@@ -888 +888 @@
                             // translators: %1$s is the file name, %2$s is the json error message.
                             __( 'Error attempting to parse json in %1$s: %2$s', 'wporg-plugins' ),
-                            '<code>' . $this->relative_filename( $block_json_file ) . '</code>',
+                            '<code><a href="' . $this->get_browser_url( $block_json_file ) . '">' . $this->relative_filename( $block_json_file ) . '</a></code>',
                             $message
                         ),
@@ -923 +923 @@
                             __FUNCTION__,
                             ( 'error' === $code ? 'warning' : $code ), // TODO: be smarter about mapping these
-                            '<code>' . $this->relative_filename( $block_json_file ) . '</code>: ' . $message,
+                            '<code><a href="' . $this->get_browser_url( $block_json_file ) . '">' . $this->relative_filename( $block_json_file ) . '</a></code>: ' . $message,
                             array(
                                 $this->relative_filename( $block_json_file ),