Making WordPress.org


Ignore:
Timestamp:
08/19/2020 06:09:34 AM (4 years ago)
Author:
coffee2code
Message:

Developer, CLI Handbook: Change the view open/closed GitHub ticket URLs to pass through GH's login page.

These links are to queries that require the GH user to be logged in and 404 if they aren't. This approach at least makes it clear that they need to log in and will redirect them to desired page once they do so.

Props felipeloureirosantos, dd32.
Fixes #5379.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/cli.php

    r9757 r10185  
    322322        $repo_url = get_post_meta( get_the_ID(), 'repo_url', true );
    323323        $cmd_slug = str_replace( 'wp ', '', get_the_title() );
    324         $open_issues = 'https://github.com/issues?q=label%3A' . urlencode( 'command:' . str_replace( ' ', '-', $cmd_slug ) ) . '+sort%3Aupdated-desc+org%3Awp-cli+is%3Aopen';
    325         $closed_issues = 'https://github.com/issues?q=label%3A' . urlencode( 'command:' . str_replace( ' ', '-', $cmd_slug ) ) . '+sort%3Aupdated-desc+org%3Awp-cli+is%3Aclosed';
     324        $open_issues = 'https://github.com/login?return_to=%2Fissues%3Fq%3Dlabel%3A' . urlencode( 'command:' . str_replace( ' ', '-', $cmd_slug ) ) . '+sort%3Aupdated-desc+org%3Awp-cli+is%3Aopen';
     325        $closed_issues = 'https://github.com/login?return_to=%2Fissues%3Fq%3Dlabel%3A' . urlencode( 'command:' . str_replace( ' ', '-', $cmd_slug ) ) . '+sort%3Aupdated-desc+org%3Awp-cli+is%3Aclosed';
    326326        $issue_count = array( 'open' => false, 'closed' => false );
    327327        foreach( $issue_count as $type => $value ) {
Note: See TracChangeset for help on using the changeset viewer.