Changeset 10190

Timestamp:

08/19/2020 10:24:15 PM (5 years ago)

Author:

coffee2code

Message:

Developer, Code Standards Handbook: Fix (as a stopgap) double-encoding of HTML entities.

SyntaxHighligher Evolved's handling of HTML entities in code shortcodes is the likely culprit. Use of triple backticks in the source Markdown files to denote code blocks (as done in the Block Editor Handbook) could circumvent the issue.

Props kmarcink, coffee2code.
Fixes #5346.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/import-coding-standards.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/import-coding-standards.php

@@ -13 +13 @@
 
         add_filter( 'handbook_label', array( $this, 'change_handbook_label' ), 10, 2 );
+        add_filter( 'the_content', array( $this, 'fix_double_encoding' ) );
     }
 
@@ -31 +32 @@
         return $label;
     }
+
+    /**
+     * Fixes (as a stopgap) encoding of already encoded characters in code shortcodes.
+     *
+     * Affected characters:
+     * - '&` (sometimes)
+     * - `<`
+     * - `*` (when encoded in the first place)
+     * - `?` (when encoded in the first place)
+     * - `"` (in some places when used as opening quote)
+     *
+     * This could probably be abrogated by the source using triple backticks to
+     * denote code.
+     *
+     * @see https://meta.trac.wordpress.org/ticket/5346
+     *
+     * @param string $content Post content.
+     * @return string
+     */
+    public function fix_double_encoding( $content ) {
+        if ( $this->get_post_type() === get_post_type() ) {
+            $content = str_replace(
+                [ '&amp;amp;', '&amp;042;', '&amp;#042;', '&amp;lt;', '&amp;quest;', '&amp;quot;' ],
+                [ '&amp;', '&#042;', '&#042;', '&lt;', '&quest;', '&quot;' ],
+                $content
+            );
+        }
+        return $content;
+    }
 }