Changeset 10214 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

Timestamp:

08/28/2020 05:36:38 AM (4 years ago)

Author:

dd32

Message:

Plugin Directory: Add an initial run at Release Confirmation for plugins.

This is currently only enabled for plugin review members, as it needs some testing in production prior to being available to others.

Notably, this requires that a plugin be using tagged releases, it doesn't handle trunk releases (yet), that will be added next.

See: #5352

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php (modified) (5 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

@@ -7 +7 @@
 use WordPressdotorg\Plugin_Directory\Block_JSON;
 use WordPressdotorg\Plugin_Directory\Plugin_Directory;
+use WordPressdotorg\Plugin_Directory\Email\Release_Confirmation as Release_Confirmation_Email;
 use WordPressdotorg\Plugin_Directory\Readme\Parser;
 use WordPressdotorg\Plugin_Directory\Template;
@@ -75 +76 @@
         $headers         = $data['plugin_headers'];
         $stable_tag      = $data['stable_tag'];
+        $last_committer  = $data['last_committer'];
+        $last_revision   = $data['last_revision'];
         $tagged_versions = $data['tagged_versions'];
         $last_modified   = $data['last_modified'];
         $blocks          = $data['blocks'];
         $block_files     = $data['block_files'];
+
+        // Release confirmation
+        if ( $plugin->release_confirmation ) {
+            if ( 'trunk' === $stable_tag ) {
+                throw new Exception( 'Plugin cannot be released from trunk due to release confirmation being enabled.' );
+            }
+
+            $release = Plugin_Directory::get_release( $plugin, $stable_tag );
+
+            // This tag is unknown? Trigger email.
+            if ( ! $release ) {
+                Plugin_Directory::add_release(
+                    [
+                        'tag'       => $stable_tag,
+                        'version'   => $headers->Version,
+                        'committer' => [ $last_committer ],
+                        'revision'  => [ $last_revision ]
+                    ]
+                );
+
+                $email = new Release_Confirmation_Email(
+                    $plugin,
+                    Tools::get_plugin_committers( $plugin_slug ),
+                    [
+                        'release' => $releases[ $stable_tag ],
+                        'who'     => $last_committer,
+                        'readme'  => $readme,
+                        'headers' => $headers,
+                    ]
+                );
+                $email->send();
+
+                throw new Exception( 'Plugin release not confirmed; email triggered.' );
+            }
+
+            // Check that the tag is approved.
+            if ( ! $release['confirmed'] ) {
+
+                if ( ! in_array( $last_committer, $release['committer'], true ) ) {
+                    $release['committer'][] = $last_committer;
+                }
+                if ( ! in_array( $last_revision, $release['revision'], true ) ) {
+                    $release['revision'][] = $last_revision;
+                }
+
+                // Update with ^
+                Plugin_Directory::add_release( $plugin, $release );
+
+                throw new Exception( 'Plugin release not confirmed.' );
+            }
+
+            // At this point we can assume that the release was confirmed, and should be imported.
+        }
 
         $content = '';
@@ -261 +317 @@
         }
 
+        $plugin = Plugin_Directory::get_plugin_post( $plugin_slug );
+
+        // Don't rebuild release-confirmation-required tags.
+        if ( $plugin->release_confirmation ) {
+            foreach ( $versions_to_build as $i => $tag ) {
+                $release = Plugin_Directory::get_release( $plugin, $tag );
+
+                if ( ! $release || ( $release['zips_built'] && $release['confirmations_required'] ) ) {
+                    unset( $versions_to_build[ $i ] );
+                } else {
+                    $release['zips_built'] = true;
+                    Plugin_Directory::add_release( $release );
+                }
+
+            }
+        }
+
+        if ( ! $versions_to_build ) {
+            return false;
+        }
+
         // Rebuild/Build $build_zips
         try {
@@ -390 +467 @@
         }
 
+        $last_committer = $svn_info['result']['Last Changed Author'] ?? '';
+        $last_revision  = $svn_info['result']['Last Changed Rev'] ?? 0;
+
         $svn_export = SVN::export(
             $stable_url,
@@ -549 +629 @@
         } ) );
 
-        return compact( 'readme', 'stable_tag', 'last_modified', 'tmp_dir', 'plugin_headers', 'assets', 'tagged_versions', 'blocks', 'block_files' );
+        return compact( 'readme', 'stable_tag', 'last_modified', 'last_committer', 'last_revision', 'tmp_dir', 'plugin_headers', 'assets', 'tagged_versions', 'blocks', 'block_files' );
     }