Changeset 10215 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

Timestamp:

08/28/2020 05:42:34 AM (6 years ago)

Author:

dd32

Message:

Plugin Directory: Release Confirmation: Ensure that only one release can exist per tag in the releases array.

See #5352.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -1601 +1601 @@
                 ];
 
-                // Fill
+                // Fill the $release with the newish data. This could/should use wp_parse_args()?
                 foreach ( $data as $k => $v ) {
                         $release[ $k ] = $v;
@@ -1608 +1608 @@
                 $releases = self::get_releases( $plugin );
 
+                // Find any other releases using this slug (as in the case of updates) and remove it.
+                // Only one release can exist in any given tag.
+                foreach ( $releases as $i => $r ) {
+                        if ( $r['tag'] === $release['tag'] ) {
+                                unset( $releases[ $i ] );
+                        }
+                }
+
+                // Add this release in
                 $releases[] = $release;