Changeset 10221

Timestamp:

08/29/2020 12:04:16 AM (4 years ago)

Author:

dd32

Message:

Plugin Directory: Release Confirmations: Don't log disabling the feature when it was already disabled.

See #5352.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• admin/metabox/class-release-confirmation.php (modified) (1 diff)
• api/routes/class-plugin-release-confirmation.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-release-confirmation.php

@@ -42 +42 @@
             current_user_can( 'plugin_admin_edit', $post_id )
         ) {
-            if ( 0 == $_REQUEST['release_confirmation'] ) {
+            if ( $_REQUEST['release_confirmation'] == get_post_meta( $post_id, 'release_confirmation', true ) ) {
+                // Do nothing, it's all good.
+            } else if ( 0 == $_REQUEST['release_confirmation'] ) {
                 // Disable
-                Tools::audit_log( 'Plugin release approval disabled.', $post_id );
+                Tools::audit_log( 'Plugin release confirmation disabled.', $post_id );
                 update_post_meta( $post_id, 'release_confirmation', 0 );
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-release-confirmation.php

@@ -117 +117 @@
 
         // Fetch the releases first, to prefill them if needed with the old release_confirmation count.
-        Plugin_Directory::get_releases();
+        Plugin_Directory::get_releases( $plugin );
 
         // Update the Metadata.