Changeset 10229 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-block-validator.php

Timestamp:

09/02/2020 04:13:40 AM (4 years ago)

Author:

dd32

Message:

Plugin Directory: Block Validator: Avoid a PHP Warning when a plugin belongs to no sections.

get_the_terms() returns false when a post has no terms, an array of terms, or a WP_Error on failure (which we're ignoring here).

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-block-validator.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-block-validator.php

@@ -122 +122 @@
         if ( $post && wp_verify_nonce( $_POST['block-directory-nonce'], 'block-directory-edit-' . $post->ID ) ) {
             if ( current_user_can( 'edit_post', $post->ID ) || current_user_can( 'plugin_admin_edit', $post->ID ) ) {
-                $terms = wp_list_pluck( get_the_terms( $post->ID, 'plugin_section' ), 'slug' );
+                $terms = wp_list_pluck( get_the_terms( $post->ID, 'plugin_section' ) ?: [], 'slug' );
                 if ( 'add' === $_POST['block-directory-edit'] ) {
                     $terms[] = 'block';