Changeset 10250

Timestamp:

09/11/2020 04:41:56 PM (5 years ago)

Author:

iandunn

Message:

Events: Disable caching during manual tests for convenience.

Location:

sites/trunk/api.wordpress.org/public_html/events/1.0

Files:

• index.php (modified) (2 diffs)
• tests/test-index.php (modified) (1 diff)

sites/trunk/api.wordpress.org/public_html/events/1.0/index.php

@@ -40 +40 @@
     // The test suite just needs the functions defined and doesn't want any headers or output
     if ( defined( 'RUNNING_TESTS' ) && RUNNING_TESTS ) {
+        disable_caching();
         return;
     }
 
-    wp_cache_init();
+    // Disable object caching during manual testing, unless explicitly testing caching.
+    if ( is_test_request() && empty( $_GET['cache'] ) ) {
+        disable_caching();
+    } else {
+        wp_cache_init();
+    }
 
     $cache_group   = 'events';
@@ -53 +59 @@
 
     send_response( $response, $ttl );
+}
+
+/**
+ * Determine if the current request is a developer manually testing on their sandbox.
+ *
+ * @return bool
+ */
+function is_test_request() {
+    $proxied = defined( 'WPORG_PROXIED_REQUEST' ) && WPORG_PROXIED_REQUEST;
+    $sandbox = defined( 'WPORG_SANDBOXED' ) && WPORG_SANDBOXED;
+
+    return $proxied && $sandbox;
+}
+
+/**
+ * Mock the caching functions.
+ */
+function disable_caching() {
+    /**
+     * Stub to simulate cache misses, so that the tests always get fresh results
+     *
+     * @return false
+     */
+    function wp_cache_get( $key, $group = '', $force = false, &$found = null ) {
+        return false;
+    }
+
+    /**
+     * Stub to avoid setting production object cache values while testing.
+     */
+    function wp_cache_set( $key, $data, $group = '', $expire = 0 ) {
+        // Intentionally empty
+    }
 }
 

sites/trunk/api.wordpress.org/public_html/events/1.0/tests/test-index.php

@@ -1530 +1530 @@
 }
 
-/**
- * Stub to simulate cache misses, so that the tests always get fresh results
- *
- * @return false
- */
-function wp_cache_get( $key, $group = '', $force = false, &$found = null ) {
-    return false;
-}
-
-/**
- * Stub to simulate cache misses, so that the tests always get fresh results
- */
-function wp_cache_set( $key, $data, $group = '', $expire = 0 ) {
-    // Intentionally empty
-}
-
-
 define( 'VERBOSE_OUTPUT', in_array( '--verbose', $argv, true ) );