Changeset 10266

Timestamp:

09/16/2020 06:02:02 AM (5 years ago)

Author:

dd32

Message:

Trac: Make the whole text of ticket actions clickable.

Trac templates only have the first word of the action clickable, for example: <label>close</label> as fixed
This simply moves the following text node (as fixed) into the label contents, avoiding selecting the following <input> and <span>.

Location:

sites/trunk

Files:

• trac.wordpress.org/templates/site.html (modified) (1 diff)
• wordpress.org/public_html/style/trac/wp-trac.js (modified) (1 diff)

sites/trunk/trac.wordpress.org/templates/site.html

@@ -5 +5 @@
 
 <?python
-    scripts_version = '146'
+    scripts_version = '147'
     project_slug = req.environ['HTTP_HOST'].split(':')[0].split('.')[0]
     wporg_endpoint = 'https://make.wordpress.org/' + project_slug + '/'

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -355 +355 @@
                     }
                 });
+
+                // Move all of the ticket actions text into the label.
+                // Trac markup is like this: `<label>close</label> as fixed`
+                jQuery('#action div label' ).each( function() {
+                    if ( this.nextSibling && Node.TEXT_NODE === this.nextSibling.nodeType ) {
+                        this.textContent += this.nextSibling.nodeValue;
+                        this.nextSibling.nodeValue = '';
+                    }
+                } );
 
                 // Point users to open new tickets when they comment on old tickets.