Changeset 10275

Timestamp:

09/17/2020 01:22:41 AM (4 years ago)

Author:

dd32

Message:

Rosetta: Prevent custom_links menu items being upgraded to the 'Get WordPress' button when they appear in the menu before the download link.

This was causing the Pirate translation site to have a Downloads menu item and a downloads button that pointed to the Theme Directory.

Fixes #5433.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/rosetta/inc/class-plugin.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/rosetta/inc/class-plugin.php

@@ -34 +34 @@
     private function __construct() {
         add_action( 'plugins_loaded', [ $this, 'plugins_loaded' ], 1 );
-        add_action( 'wp_nav_menu_objects', [ $this, 'download_button_menu_item' ], 11 );
+        add_filter( 'wp_nav_menu_objects', [ $this, 'download_button_menu_item' ], 11 );
 
         $this->sites = [
@@ -73 +73 @@
     public function download_button_menu_item( $menu_items ) {
         foreach ( $menu_items as $menu_item ) {
-            if ( false !== stripos( $menu_item->url, 'download/' ) || 'page-download.php' === get_page_template_slug( $menu_item->object_id ) ) {
+            if (
+                false !== stripos( $menu_item->url, 'download/' ) ||
+                (
+                    $menu_item->object_id &&
+                    'post_type' == $menu_item->type &&
+                    'page-download.php' === get_page_template_slug( $menu_item->object_id )
+                )
+            ) {
+                $menu_item->ID      = -1; // Prevents the title being overwritten by the page title.
                 $menu_item->classes = array_merge( $menu_item->classes, ['button', 'button-primary', 'download'] );
                 $menu_item->title   = _x( 'Get WordPress', 'Menu title', 'rosetta' );