Changeset 10288 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/register.php

Timestamp:

09/26/2020 01:46:31 AM (5 years ago)

Author:

dd32

Message:

Login: Don't allow usernames with trailing spaces or other whitespace around it.

A handful of new registrations included a space trailing their username which caused the confirmation emails to include invalid activation links.

See ​https://wordpress.slack.com/archives/C08M59V3P/p1601053672001300

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/register.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/register.php

@@ -6 +6 @@
  */
 
-$user_login = isset( $_POST['user_login'] ) ? wp_unslash( $_POST['user_login'] ) : '';
+$user_login = isset( $_POST['user_login'] ) ? trim( wp_unslash( $_POST['user_login'] ) ) : '';
 if ( ! $user_login && !empty( WP_WPOrg_SSO::$matched_route_params['user'] ) ) {
-    $user_login = WP_WPOrg_SSO::$matched_route_params['user'];
+    $user_login = trim( WP_WPOrg_SSO::$matched_route_params['user'] );
 }
-$user_email = isset( $_POST['user_email'] ) ? wp_unslash( $_POST['user_email'] ) : '';
+$user_email = isset( $_POST['user_email'] ) ? trim( wp_unslash( $_POST['user_email'] ) ) : '';
 $user_mailinglist = isset( $_POST['user_mailinglist'] ) && 'true' == $_POST['user_mailinglist'];