Changeset 10296 for sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-themes-api.php

Timestamp:

09/29/2020 02:16:23 AM (6 years ago)

Author:

dd32

Message:

Theme Directory: API: Better handling for invalid or missing user field when requesting user favorites.

Fixes a PHP Notice when it's unset and unexpected results when it's invalid.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-themes-api.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-themes-api.php

@@ -99 +99 @@
                         'author',
                         'browse',
+                        'user',
                         'locale',
                         'per_page',
@@ -111 +112 @@
                                 $this->bad_input = true;
                         }
+                }
+
+                // Favorites requests require a user to fetch favorites for.
+                if ( isset( $this->request->browse ) && 'favorites' === $this->request->browse && ! isset( $this->request->user ) ) {
+                        $this->request->user = '';
+                        $this->bad_input = true;
                 }
 
@@ -547 +554 @@
                                 $this->cache_life = HOUR_IN_SECONDS;
                         } elseif ( 'favorites' == $this->request->browse ) {
-                                $this->query['favorites_user'] = (string) $this->request->user;
+                                $this->query['favorites_user'] = $this->request->user;
                         }