Changeset 10311 for sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/theme-directory.php

Timestamp:

09/29/2020 05:59:41 AM (5 years ago)

Author:

dd32

Message:

Theme Directory: Upload: Handle invalid/missing theme meta more gracefully.

This avoids a PHP Notice when the status of the current version of the theme is unknown, which seems it can happen for new not-yet-approved themes.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/theme-directory.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/theme-directory.php

@@ -393 +393 @@
  */
 function wporg_themes_update_version_status( $post_id, $current_version, $new_status ) {
-    $meta = get_post_meta( $post_id, '_status', true );
-
-    if ( empty( $meta ) ) {
-        $meta = array();
-        $old_status = false;
-    } else {
+    $meta = get_post_meta( $post_id, '_status', true ) ?: array();
+
+    $old_status = false;
+    if ( isset( $meta[ $current_version ] ) ) {
         $old_status = $meta[ $current_version ];
     }