Changeset 10322 for sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/query-modifications.php

Timestamp:

09/30/2020 01:45:40 AM (4 years ago)

Author:

dd32

Message:

Theme Directory: Avoid PHP Notices when favorites are requested for a non-existant user.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/query-modifications.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/query-modifications.php

@@ -72 +72 @@
             $favorites = array();
 
+            $user_id = 0;
             if ( ! empty( $query->query_vars['favorites_user'] ) ) {
-                $user_id = get_user_by( 'login', $query->query_vars['favorites_user'] )->ID;
+                $user = get_user_by( 'login', $query->query_vars['favorites_user'] );
+                if ( $user ) {
+                    $user_id = $user->ID;
+                }
             } elseif ( is_user_logged_in() ) {
                 $user_id = get_current_user_id();
             }
 
-            if ( ! empty( $user_id ) ) {
+            if ( $user_id ) {
                 $favorites = array_filter( (array) get_user_meta( $user_id, 'theme_favorites', true ) );
             }