Changeset 10349

Timestamp:

10/06/2020 04:13:41 AM (5 years ago)

Author:

dd32

Message:

Support Forum: Don't assume that the plugin or theme actually exists, the metadata for threads can get out of sync with reality causing it to constantly query for a plugin/theme it'll never get valid data for.

Fixes a bunch of PHP notices.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php

@@ -887 +887 @@
 
         // Check the cache.
-        $cache_key = $slug;
+        $cache_key   = $slug;
         $cache_group = $this->compat() . '-authors-slugs';
-        $authors = wp_cache_get( $cache_key, $cache_group );
-        if ( ! $authors ) {
-
+        $authors     = wp_cache_get( $cache_key, $cache_group );
+        if ( $authors === false ) {
+            $authors = array();
             if ( $this->compat() == 'theme' ) {
                 $theme = $this->get_object( $slug );
-                $author = get_user_by( 'id', $theme->post_author );
-                $authors = array( $author->user_nicename );
+                if ( $theme ) {
+                    $author = get_user_by( 'id', $theme->post_author );
+                    if ( $author ) {
+                        $authors = array( $author->user_nicename );
+                    }
+                }
             } else {
                 $plugin = $this->get_object( $slug );
-                $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
-                // Note: Intentionally not considering posts of 'plugin' post_type with
-                // 'post_author' matching this author because the field only relates to
-                // the user who submitted the plugin. It does not confer special access,
-                // rights, or ownership.
-                $authors = $wpdb->get_col( $wpdb->prepare(
+                if ( $plugin ) {
+                    $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
+                    // Note: Intentionally not considering posts of 'plugin' post_type with
+                    // 'post_author' matching this author because the field only relates to
+                    // the user who submitted the plugin. It does not confer special access,
+                    // rights, or ownership.
+                    $authors = $wpdb->get_col( $wpdb->prepare(
+                        "SELECT slug
+                         FROM {$prefix}terms AS t
+                         LEFT JOIN {$prefix}term_taxonomy AS tt ON tt.term_id = t.term_id
+                         LEFT JOIN {$prefix}term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id
+                         WHERE tt.taxonomy = 'plugin_committers' AND tr.object_id = %d",
+                         $plugin->ID
+                    ) );
+                }
+            }
+
+            wp_cache_set( $cache_key, $authors, $cache_group, HOUR_IN_SECONDS );
+        }
+        return $authors;
+    }
+
+    public function get_contributors( $slug ) {
+        global $wpdb;
+
+        if ( null !== $this->contributors ) {
+            return $this->contributors;
+        }
+
+        // Themes do not have contributors right now.
+        if ( $this->compat() == 'theme' ) {
+            $contributors = array();
+            return $contributors;
+        }
+
+        // Check the cache.
+        $cache_key    = $slug;
+        $cache_group  = $this->compat() . '-contributors-slugs';
+        $contributors = wp_cache_get( $cache_key, $cache_group );
+        if ( $contributors === false ) {
+            $contributors = array();
+            $plugin       = $this->get_object( $slug );
+
+            if ( $plugin ) {
+                $prefix       = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
+                $contributors = $wpdb->get_col( $wpdb->prepare(
                     "SELECT slug
                      FROM {$prefix}terms AS t
                      LEFT JOIN {$prefix}term_taxonomy AS tt ON tt.term_id = t.term_id
                      LEFT JOIN {$prefix}term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id
-                     WHERE tt.taxonomy = 'plugin_committers' AND tr.object_id = %d",
+                     WHERE tt.taxonomy = 'plugin_contributors' AND tr.object_id = %d",
                      $plugin->ID
                 ) );
             }
 
-            wp_cache_set( $cache_key, $authors, $cache_group, HOUR_IN_SECONDS );
-        }
-        return $authors;
-    }
-
-    public function get_contributors( $slug ) {
-        global $wpdb;
-
-        if ( null !== $this->contributors ) {
-            return $this->contributors;
-        }
-
-        // Themes do not have contributors right now.
-        if ( $this->compat() == 'theme' ) {
-            $contributors = array();
-            return $contributors;
-        }
-
-        // Check the cache.
-        $cache_key = $slug;
-        $cache_group = $this->compat() . '-contributors-slugs';
-        $contributors = wp_cache_get( $cache_key, $cache_group );
-        if ( ! $contributors ) {
-            $plugin = $this->get_object( $slug );
-            $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
-            $contributors = $wpdb->get_col( $wpdb->prepare(
-                "SELECT slug
-                 FROM {$prefix}terms AS t
-                 LEFT JOIN {$prefix}term_taxonomy AS tt ON tt.term_id = t.term_id
-                 LEFT JOIN {$prefix}term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id
-                 WHERE tt.taxonomy = 'plugin_contributors' AND tr.object_id = %d",
-                 $plugin->ID
-            ) );
-
             wp_cache_set( $cache_key, $contributors, $cache_group, HOUR_IN_SECONDS );
         }
+
         return $contributors;
     }
@@ -966 +977 @@
 
         // Check the cache.
-        $cache_key = $slug;
-        $cache_group = $this->compat() . '-support-reps-slugs';
+        $cache_key    = $slug;
+        $cache_group  = $this->compat() . '-support-reps-slugs';
         $support_reps = wp_cache_get( $cache_key, $cache_group );
-        if ( ! $support_reps ) {
-            $plugin = $this->get_object( $slug );
-            $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
-            $support_reps = $wpdb->get_col( $wpdb->prepare(
-                "SELECT slug
-                 FROM {$prefix}terms AS t
-                 LEFT JOIN {$prefix}term_taxonomy AS tt ON tt.term_id = t.term_id
-                 LEFT JOIN {$prefix}term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id
-                 WHERE tt.taxonomy = 'plugin_support_reps' AND tr.object_id = %d",
-                 $plugin->ID
-            ) );
+        if ( $support_reps === false ) {
+            $support_reps = array();
+            $plugin       = $this->get_object( $slug );
+
+            if ( $plugin ) {
+                $prefix       = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
+                $support_reps = $wpdb->get_col( $wpdb->prepare(
+                    "SELECT slug
+                     FROM {$prefix}terms AS t
+                     LEFT JOIN {$prefix}term_taxonomy AS tt ON tt.term_id = t.term_id
+                     LEFT JOIN {$prefix}term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id
+                     WHERE tt.taxonomy = 'plugin_support_reps' AND tr.object_id = %d",
+                     $plugin->ID
+                ) );
+            }
 
             wp_cache_set( $cache_key, $support_reps, $cache_group, HOUR_IN_SECONDS );
         }
+
         return $support_reps;
     }