Changeset 10352

Timestamp:

10/06/2020 07:33:26 AM (6 years ago)

Author:

dd32

Message:

Plugin Directory: Ensure that all locale translated text gets synced to postmeta so as to get synced to Jetpack ElasticSearch.

See #1496.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php (modified) (7 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -1067 +1067 @@
          * Fetch all translated content for a given post, and push it into postmeta.
          *
-         * @global string $locale Current locale.
-         *
-         * @param int $post_id    Post ID to update.
+         * @param int|string|WP_Post $plugin Plugin to update.
          * @param int $min_translated Translations below this % threshold will not be synced to meta, to save space.
          * @return array
          */
-        public function sync_all_translations_to_meta( $post_id, $min_translated = 40, $skip_pfx = array( 'en_' ) ) {
+        public function sync_all_translations_to_meta( $plugin, $min_translated = 40, $skip_pfx = array( 'en_' ) ) {
 
                 $locales_to_sync = array();
-                $post            = get_post( $post_id );
+                $post            = self::get_plugin_post( $plugin );
                 if ( $post ) {
                         $project = 'stable-readme';
@@ -1082 +1080 @@
                                 $project = 'dev-readme';
                         }
+
                         $translations = Plugin_I18n::instance()->find_all_translations_for_plugin( $post->post_name, $project, $min_translated ); // at least $min_translated % translated
                         if ( $translations ) {
@@ -1098 +1097 @@
                 if ( count( $locales_to_sync ) > 0 ) {
                         foreach ( $locales_to_sync as $locale ) {
-                                $this->sync_translation_to_meta( $post_id, $locale );
+                                $this->sync_translation_to_meta( $post->ID, $locale );
                         }
                 }
@@ -1107 +1106 @@
         /**
          * Fetch translated content for a given post and locale, and push it into postmeta.
-         *
-         * @global string $locale Current locale.
          *
          * @param int    $post_id    Post ID to update.
@@ -1121 +1118 @@
                 // Update postmeta values for the translated title, excerpt, and content, if they are available and different from the originals.
                 // There is a bug here, in that no attempt is made to remove old meta values for translations that do not have new translations.
-                $the_title = Plugin_I18n::instance()->translate( 'title', $orig_title, [ 'post_id' => $post_id ] );
+                $the_title = Plugin_I18n::instance()->translate( 'title', $orig_title, [ 'post_id' => $post_id, 'locale' => $locale ] );
                 if ( $the_title && $the_title != $orig_title ) {
                         update_post_meta( $post_id, 'title_' . $locale, $the_title );
                 }
 
-                $the_excerpt = $this->translate_post_excerpt( $orig_excerpt, $post_id );
+                $the_excerpt =  Plugin_I18n::instance()->translate( 'excerpt', $orig_excerpt, [ 'post_id' => $post_id, 'locale' => $locale ] );
                 if ( $the_excerpt && $the_excerpt != $orig_excerpt ) {
                         update_post_meta( $post_id, 'excerpt_' . $locale, $the_excerpt );
@@ -1135 +1132 @@
                 $sections    = $this->split_post_content_into_pages( $orig_content );
                 foreach ( $sections as $section => $section_content ) {
-                        $translated_section = $this->translate_post_content( $section_content, $section, $post_id );
+                        $translated_section = Plugin_I18n::instance()->translate( $section, $section_content, [ 'post_id' => $post_id, 'locale' => $locale ] );
                         if ( $translated_section && $translated_section != $section_content ) {
                                 // ES expects the section delimiters to still be present
@@ -1149 +1146 @@
                 $existing_translated_titles = array_unique( get_post_meta( $post_id, 'block_title_' . $locale ) );
                 foreach ( array_unique( get_post_meta( $post_id, 'block_title' ) ) as $block_title ) {
-                        $translated_title = Plugin_I18n::instance()->translate( 'block_title:' . md5( $block_title ), $block_title, [ 'post_id' => $post_id ] );
+                        $translated_title = Plugin_I18n::instance()->translate( 'block_title:' . md5( $block_title ), $block_title, [ 'post_id' => $post_id, 'locale' => $locale ] );
 
                         if ( $translated_title == $block_title ) {