Changeset 10357

Timestamp:

10/11/2020 03:40:09 PM (4 years ago)

Author:

ocean90

Message:

Translate: Don't show suggestions if user cannot add/edit translations.

See #5471.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins

Files:

• wporg-gp-customizations/templates/translation-row-editor.php (modified) (2 diffs)
• wporg-gp-translation-suggestions/inc/class-plugin.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates/translation-row-editor.php

@@ -206 +206 @@
                                 </div>
                             <?php elseif ( is_user_logged_in() ) : ?>
-                                You are not allowed to edit this translation.
+                                <?php echo apply_filters( 'wporg_translate_cannot_edit_translation_hint', '<p class="info">Sorry, you are not allowed to edit this translation.</p>', $translation ); ?>
                             <?php else : ?>
                                 <p class="info">
@@ -221 +221 @@
 
                     <?php
-                    if ( has_action( 'wporg_translate_suggestions' ) ) {
+                    if ( $can_edit && has_action( 'wporg_translate_suggestions' ) ) {
                         ?>
                         <div class="suggestions-wrapper">

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-translation-suggestions/inc/class-plugin.php

@@ -105 +105 @@
      */
     public function pre_tmpl_load( $template, $args ) {
-        if ( 'translations' !== $template || ! is_user_logged_in() ) {
+        if ( 'translations' !== $template || ! isset( $args['translation_set']->id ) || ! GP::$permission->current_user_can( 'edit', 'translation-set', $args['translation_set']->id ) ) {
             return;
         }
@@ -143 +143 @@
      */
     public function extend_translation_suggestions( $entry ) {
-        if ( ! is_user_logged_in() ) {
+        if ( ! isset( $entry->translation_set_id ) || ! GP::$permission->current_user_can( 'edit', 'translation-set', $entry->translation_set_id ) ) {
             return;
         }