Changeset 10383 for sites/trunk/global.wordpress.org/public_html/wp-content/mu-plugins/showcase/rosetta-showcase.php

Timestamp:

10/16/2020 04:13:14 AM (4 years ago)

Author:

dd32

Message:

Rosetta: Showcase: Rosetta showcases aren't "public" as they don't have individual showcase pages, only a rotating section on the homepage.

This was causing Canonical to pick up showcase entries on 404 pages (ie. /five/ might attempt to redirect to a showcase site called 'Five Fingers') and cause PHP Notices.
No redirect was possible, as core correctly didn't redirect cross-domain, but it resulted in notices and a redirect to the homepage instead of a better destination.

File:

• sites/trunk/global.wordpress.org/public_html/wp-content/mu-plugins/showcase/rosetta-showcase.php (modified) (1 diff)

sites/trunk/global.wordpress.org/public_html/wp-content/mu-plugins/showcase/rosetta-showcase.php

@@ -62 +62 @@
         $args = [
             'labels'               => $labels,
-            'public'               => true,
+            'public'               => false,
             'show_ui'              => true,
             'rewrite'              => false,