Changeset 10384 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

Timestamp:

10/16/2020 05:06:16 AM (4 years ago)

Author:

dd32

Message:

Plugin Directory: When querying author archives, don't assume the user exists, guards against junk requests causing notices.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -845 +845 @@
         // Author Archives need to be created
         if ( $wp_query->is_main_query() && $wp_query->is_author() ) {
-            $user = isset( $wp_query->query['author_name'] ) ? $wp_query->query['author_name'] : get_user_by( 'id', $wp_query->query['author'] )->user_nicename;
-
-            $viewing_own_author_archive = is_user_logged_in() && ( current_user_can( 'plugin_review' ) || 0 === strcasecmp( $user, wp_get_current_user()->user_nicename ) );
+            $user = false;
+            if ( isset( $wp_query->query['author_name'] ) ) {
+                $user = $wp_query->query['author_name'];
+            } elseif ( ! empty( $wp_query->query['author'] ) ) {
+                $user = get_user_by( 'id', $wp_query->query['author'] );
+                if ( $user ) {
+                    $user = $user->user_nicename;
+                }
+            }
+
+            $viewing_own_author_archive = is_user_logged_in() && $user && ( current_user_can( 'plugin_review' ) || 0 === strcasecmp( $user, wp_get_current_user()->user_nicename ) );
 
             // Author archives by default list plugins you're a contributor on.