Changeset 10446

Timestamp:

11/12/2020 06:48:44 AM (6 years ago)

Author:

dd32

Message:

Plugin Directory: i18n: Remove fulltext caching, in preference for running the translation replacement process on each request.

This seems to provide minimal benefit while increasing the amount of data pulled from the cache.
I believe it was originally for performance, but basic testing doesn't seem to be greatly affected.

This brings some compatibility with translation plugins by allowing the gettext filter to run on each sub-string.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-i18n.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-i18n.php

@@ -383 +383 @@
                 }
 
-                $cache_suffix = "{$locale}:{$key}";
-
-                // Try the cache.
-                if ( false !== ( $cache = $this->cache_get( $slug, $branch, $cache_suffix ) ) ) {
-                        // DEBUG
-                        // var_dump( array( $slug, $branch, $cache_suffix, $cache ) );
-                        return $cache;
-                }
-
                 $originals = $this->get_gp_originals( $slug, $branch, $key, $content );
 
@@ -423 +414 @@
                 // Translate the marked originals.
                 $content = $this->translate_marked_gp_originals( $content, $translations, $originals );
-
-                $this->cache_set( $slug, $branch, $content, $cache_suffix );
 
                 return $content;