Changeset 10479

Timestamp:

12/01/2020 05:59:22 AM (4 years ago)

Author:

dd32

Message:

Trac: Mentions handler: Disable two functions that no longer work (and haven't done so for a long time).

This PHP handler can no longer access the trac ticket subscriptions table directly, and so can't check to see if a user has blocked subscription emails or not.

See #3594.

File:

• sites/trunk/api.wordpress.org/public_html/dotorg/trac/mentions-handler.php (modified) (5 diffs)

sites/trunk/api.wordpress.org/public_html/dotorg/trac/mentions-handler.php

@@ -13 +13 @@
 
 $payload = json_decode( wp_unslash( $_POST['payload'] ) );
-
-// Debug to figure out why the incoming JSON is sometimes not able to be parsed, despite appearing to be valid.
-if ( ! $payload ) {
-    slack_dm( var_export( $_POST, true ), 'dd32' );
-}
 
 require_once WP_PLUGIN_DIR . '/wporg-notifications.php';
@@ -51 +46 @@
 
 function wporg_get_trac_ticket_subscription_status( $username, $ticket ) {
+    /*
+     * TODO: This no longer works.
+     * 
+     * The _ticket_subs table is no longer accessible from PHP, as Trac doesn't use MySQL accessible via HyperDB.
+     * 
+     * The replacement is a HTTP API call via Trac_Notifications_API::get_trac_ticket_subscription_status_for_user( $ticket, $username )
+     */
+/*
     global $wpdb;
     add_db_table( 'trac_core', '_ticket_subs' ); // HyperDB
@@ -61 +64 @@
         return (int) $status;
     }
+*/
     return false;
 }
@@ -112 +116 @@
         // If on Core Trac, a user is not a reporter, owner, or subscriber, subscribe them.
         if ( isset( $status ) && false === $status ) {
+            /*
+             * TODO: This no longer works.
+             * 
+             * The _ticket_subs table is no longer accessible from PHP, as Trac doesn't use MySQL accessible via HyperDB.
+             * 
+             * Trac_Notifications_API does not have a replacement function.
+            */
+            /*
             $wpdb->insert( '_ticket_subs', array(
                 'username' => $username,
@@ -117 +129 @@
                 'status'   => MENTIONED,
             ) );
+            */
         }