Changeset 10510 for sites/trunk/wp-themes.com/public_html/wp-content/mu-plugins/pub/open-links-in-new-window.php

Timestamp:

12/11/2020 09:31:17 AM (4 years ago)

Author:

dd32

Message:

Theme Preview: Use .href instead of .getAttribute('href') to avoid a javascript error when the attribute isn't set on the DOM element.

Props poena.
Fixes #5543.

File:

• sites/trunk/wp-themes.com/public_html/wp-content/mu-plugins/pub/open-links-in-new-window.php (modified) (1 diff)

sites/trunk/wp-themes.com/public_html/wp-content/mu-plugins/pub/open-links-in-new-window.php

@@ -11 +11 @@
     var links = document.getElementsByTagName( "a" );
     for ( var i = 0; i < links.length; i++ ) {
-        var href = links[i].getAttribute( "href" ).split( "#" )[0];
+        var href = links[i].href.split( "#" )[0];
         if ( href && base !== href.substring( 0, base.length ) ) {
             links[i].target = "_blank";