Changeset 1058

Timestamp:

12/22/2014 12:03:06 AM (12 years ago)

Author:

nacin

Message:

Update Trac security script. props jorbin, fixes #265.

File:

• sites/trunk/wordpress.org/public_html/style/trac/trac-security.js (modified) (1 diff)

sites/trunk/wordpress.org/public_html/style/trac/trac-security.js

@@ +1 @@
+/* global wp */
+window.wp = window.wp || {};
+
 (function($) {
-        var badwords, intersect;
-        badwords = [
-                'sql', 'trojan', 'rce', 'permissions', 'exploit', 'exploits', 'csrf', 'xss', 'sqli',
-                'scripting', 'vulnerability', 'vulnerabilities', 'capability', 'capabilities', 'intrusion',
-                'intrusions', 'cve', 'disclosure', 'hash', 'security', 'leakage', 'privilege', 'privileges',
-                'escape', 'unescape', 'escaped', 'unescaped', 'escapes', 'escaping', 'unescaping', 'esc_',
-                'sanitize', 'unsanitize', 'sanitizes', 'unsanitizes', 'sanitized', 'unsanitized', 'sanitization',
-                'valid', 'invalid', 'validate', 'validates', 'validation',
-                'compromise', 'escalation', 'injection', 'forgery', 'password', 'passwords'
-        ];
+        var propertyform = $( '#propertyform' ),
+                submit = propertyform.find( 'input[type="submit"]' );
 
-        intersect = function(a, b) {
-                return $.grep(a, function(i) {
-                        return $.inArray(i, b) > -1; 
-                }); 
+        if ( $( document.body ).hasClass( 'security' ) ) {
+                return;
+        }
+
+        wp.trac_security = {
+                badwords : [
+                        'sql', 'trojan', 'rce', 'permissions', 'exploit', 'exploits', 'csrf', 'xss', 'sqli',
+                        'scripting', 'vulnerability', 'vulnerabilities', 'capability', 'capabilities', 'intrusion',
+                        'intrusions', 'cve', 'disclosure', 'hash', 'security', 'leakage', 'privilege', 'privileges',
+                        'escape', 'unescape', 'escaped', 'unescaped', 'escapes', 'escaping', 'unescaping', 'esc_',
+                        'sanitize', 'unsanitize', 'sanitizes', 'unsanitizes', 'sanitized', 'unsanitized', 'sanitization',
+                        'valid', 'invalid', 'validate', 'validates', 'validation',
+                        'compromise', 'escalation', 'injection', 'forgery', 'password', 'passwords',
+                ],
+
+                intersect : function(a, b) {
+                        return $.grep(a, function(i) {
+                                return $.inArray(i, b) > -1;
+                        });
+                },
+
+                has_overlap : function(str, arr){
+                        var words = str.toLowerCase().replace(/[^a-z|\s]/g, '').split(' '),
+                                overlap = this.intersect( words, arr);
+
+                        return ( overlap.length !== 0 );
+                }
         };
 
-        $(document).ready( function() {
-                var propertyform = $( '#propertyform' ),
-                        submit = propertyform.find( 'input[type="submit"]' );
-                $( '#field-summary, #field-description' ).on( 'keyup', function() {
-                        var words, overlap;
-                        words = $(this).val().toLowerCase().split( /[^a-z]/ );
-                        overlap = intersect( badwords, words );
-                 
-                        if ( overlap.length === 0 ) {
-                                submit.prop( 'disabled', false );
-                                $( '#security-question' ).hide();
-                                return;
-                        }
+        function show_box() {
+                // We have a potential problem here
+                submit.prop( 'disabled', true );
+                if ( $( '#security-question' ).length !== 0 ) {
+                        // We've already created the checkbox
+                        $( '#security-question' ).show();
+                } else {
+                        // We need to add the checkbox
+                        $( '.buttons' ).before( '<p id="security-question"><label><input type="checkbox" name="sec_question" />' +
+                                '&nbsp;I am <strong>not</strong> reporting a security issue</label>' +
+                                ' &mdash; <a href="http://make.wordpress.org/core/handbook/reporting-security-vulnerabilities/">report security issues to security@wordpress.org</a></p>' );
+                }
 
-                        // We have a potential problem here
-                        submit.prop( 'disabled', true );
-                        if ( $( '#security-question' ).length !== 0 ){ 
-                                // We've already created the checkbox
-                                $( '#security-question' ).show();
-                        } else {
-                                // We need to add the checkbox
-                                $( '.buttons' ).before( '<p id="security-question"><label><input type="checkbox" name="sec_question" />' +
-                                        '&nbsp;I am <strong>not</strong> reporting a security issue</label>' +
-                                        ' &mdash; <a href="http://make.wordpress.org/core/handbook/reporting-security-vulnerabilities/">report security issues to security@wordpress.org</a></p>' );
-                        }
-                });
-                propertyform.on( 'change', '#security-question input', function() {
-                        submit.prop( 'disabled', ! $(this).is( ':checked' ) );
-                });
+        }
+
+        function hide_box() {
+                $( 'input[name="submit"]' ).prop( 'disabled', false );
+                $( '#sec_question' ).hide();
+        }
+
+        jQuery( '#field-summary, #field-description, #field-keywords' ).on( 'keyup', function() {
+                var entry = $(this).val();
+                
+                if ( wp.trac_security.has_overlap( entry, wp.trac_security.badwords ) ) {
+                        show_box();
+                } else {
+                        hide_box();
+                }
         });
-})(jQuery);
 
+        propertyform.on( 'change', '#security-question input', function() {
+                submit.prop( 'disabled', ! $(this).is( ':checked' ) );
+        });
+}(jQuery));