Changeset 10638

Timestamp:

02/03/2021 05:26:36 AM (4 years ago)

Author:

dd32

Message:

Support Forums: cache the result of count_users() to speed up the pageload time of wp-admin/users.php.

Although this page is rarely needed or used, when it is, it's slooow. This avoids the need for a 20-60s query on each users.php pageload.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-performance-optimizations.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-performance-optimizations.php

@@ -60 +60 @@
         add_filter( 'bbp_edit_reply_pre_set_terms',    array( $this, 'limit_topic_reply_tag_creation' ) );
 
+        // Add some caching on count_users().
+        add_filter( 'pre_count_users', array( $this, 'cache_count_users' ), 10, 3 );
     }
 
@@ -556 +558 @@
     }
 
+    /**
+     * Cache the result of `count_users()` as the Support Forums site has a lot of users.
+     * 
+     * This slows wp-admin/users.php down so much that it's hard to use when required.
+     * As these numbers don't change often, it's cached for 6 hours, which avoids a 20-60s query on each users.php pageload.
+     */
+    public function cache_count_users( $result, $strategy, $site_id ) {
+        static $running = false;
+
+        if ( $result || ! is_multisite() || $running ) {
+            return $result;
+        }
+
+        switch_to_blog( $site_id );
+
+        $result = get_site_transient( 'count_users' );
+        if ( ! $result ) {
+            $running = true;
+            $result  = count_users( $strategy, $site_id );
+            $running = false;
+
+            set_site_transient( 'count_users', $result, 6 * HOUR_IN_SECONDS );
+        }
+
+        restore_current_blog();
+
+        return $result;
+    }
 }