Changeset 1064

Timestamp:

12/23/2014 07:54:55 PM (11 years ago)

Author:

coffee2code

Message:

developer.wordpress.org: Minor changes to can_user_post_note():

• Use existing post_type_supports_user_notes() rather than duplicating its check
• Don't force post argument to be an int
• Fix @param docblock missing argument name

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php

@@ -883 +883 @@
      * Does the post type have source code?
      *
-     * @param  string  Optional. The post type name. If blank, assumes current post type.
-     *
-     * @return boolean
+     * @param  null|string $post_type Optional. The post type name. If null, assumes current post type. Default null.
+     *
+     * @return bool
      */
     function post_type_has_source_code( $post_type = null ) {
@@ -1003 +1003 @@
      * blog.
      *
-     * @param  int  $post_id The post ID.
+     * @param  bool    $open If the user can post comments in general. Disregarded.
+     * @param  WP_Post $post Post ID or post object.
      *
      * @return bool True if the user can post a note.
      */
-    function can_user_post_note( $open, $post_id ) {
+    function can_user_post_note( $open, $post ) {
 
         // Only proceed if the post type is one that has user contributed notes.
-        if ( 0 !== strpos( get_post_type( (int) $post_id ), 'wp-parser-' ) ) {
+        if ( ! post_type_supports_user_notes( get_post_type( $post ) ) ) {
             // Temporarily disable commenting that isn't for a note since various
             // changes need to take place to enable regular commenting.
@@ -1017 +1018 @@
 
         // Permit default logic to be overridden via filter that returns value other than null.
-        if ( null !== ( $can = apply_filters( 'wporg_devhub-can_user_post_note', null, $post_id ) ) ) {
+        if ( null !== ( $can = apply_filters( 'wporg_devhub-can_user_post_note', null, $post ) ) ) {
             return $can;
         }