Changeset 10640

Timestamp:

02/03/2021 05:51:21 AM (6 years ago)

Author:

dd32

Message:

Support Forums: Treat the archived post status as a pending post status via bbp_is_topic_pending() to ensure that bbPress doesn't attempt to run user_trailingslashit() on a non-pretty url.

Fixes moderators hitting a 400/403 error page when performing actions on archived threads.
See ​https://wordpress.slack.com/archives/C02QB8GMM/p1612273746169300.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-moderators.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-moderators.php

@@ -33 +33 @@
                 add_filter( 'bbp_after_has_topics_parse_args',  array( $this, 'add_post_status_to_query' ) );
                 add_filter( 'bbp_after_has_replies_parse_args', array( $this, 'add_post_status_to_query' ) );
+                add_filter( 'bbp_is_topic_pending',             array( $this, 'archived_is_pending_topic' ), 10, 2 );
 
                 // Adjust the list of admin links for topics and replies.
@@ -1038 +1039 @@
                 update_post_meta( $post_id, self::MODERATOR_META, wp_get_current_user()->user_nicename );
         }
+
+        /**
+         * Treat the archived status as a pending status to ensure that bbp_get_reply_url() doesn't slash a non-pretty url.
+         * 
+         * @param bool $topic_status Whether the topic is pending.
+         * @param int  $topic_id     The topic ID.
+         * @return bool
+         */
+        public function archived_is_pending_topic( $topic_status, $topic_id ) {
+                if (
+                        ! $topic_status &&
+                        ( bbp_get_topic_status( $topic_id ) === self::ARCHIVED )
+                ) {
+                        $topic_status = true;
+                }
+
+                return $topic_status;
+        }
 }