Changeset 10673 for sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php

Timestamp:

02/15/2021 04:03:50 AM (4 years ago)

Author:

dd32

Message:

Support Forums: Move the "Subscribe to this plugin/theme" button to the sidebar instead of before the main topic listing.

This also adds a javascript-based confirm "are you sure?" confirmation upon attempting to subscribe to the plugin/theme.

See #3456.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php

@@ -286 +286 @@
             // Add plugin- and theme-specific filters and actions.
             add_action( 'wporg_compat_view_sidebar',       array( $this, 'do_view_sidebar' ) );
+            add_action( 'wporg_compat_view_sidebar',       array( $this, 'do_subscription_link' ), 11 );
             add_action( 'wporg_compat_before_single_view', array( $this, 'do_view_header' ) );
-            add_action( 'wporg_compat_before_single_view', array( $this, 'do_subscription_link' ), 11 );
 
             // Add output filters and actions.
@@ -751 +751 @@
                 $subscribe   = esc_html__( 'Subscribe to this plugin', 'wporg-forums' );
                 $unsubscribe = esc_html__( 'Unsubscribe from this plugin', 'wporg-forums' );
+                $js_confirm  = esc_html__( 'Are you sure you wish to subscribe by email to all future topics created in this plugin forum?', 'wporg-forums' );
             } else {
                 $subscribe   = esc_html__( 'Subscribe to this theme', 'wporg-forums' );
                 $unsubscribe = esc_html__( 'Unsubscribe from this theme', 'wporg-forums' );
+                $js_confirm  = esc_html__( 'Are you sure you wish to subscribe by email to all future topics created in this theme forum?', 'wporg-forums' );
             }
             $term_subscription = Term_Subscription\Plugin::get_subscription_link( array(
@@ -760 +762 @@
                 'subscribe'   => $subscribe,
                 'unsubscribe' => $unsubscribe,
+                'js_confirm'  => $js_confirm,
             ) );
         }