Changeset 10686

Timestamp:

02/17/2021 04:58:29 AM (4 years ago)

Author:

dd32

Message:

Translate: Automatically correct the case of sprintf format placeholders to their correct case.

This only applies to a sub-set of placeholders which can only be lower-case %[bcdosu], not those which can be both cases but mean different things: %[EFGX]
The most common %s and %d placeholders are covered by this, so %S / %D will be corrected.

See #5154.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-translation-fixer/wporg-gp-translation-fixer.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-translation-fixer/wporg-gp-translation-fixer.php

@@ -65 +65 @@
                     case 'placeholders':
                         // Try replacing unicode percent signs with a ascii percent sign.
-                        $translation = preg_replace( '!(﹪|％)((\d+\$(?:\d+)?)?[bcdefgosuxEFGX])!', '%$2', $translation );
+                        $translation = preg_replace( '!(﹪|％)((\d+\$(?:\d+)?)?[bcdefgosux])!i', '%$2', $translation );
 
                         // Try replacing spaced translation type with no spaces `% 1 $ s` (Machine translated text)
                         $translation = preg_replace_callback(
-                            '!%\s?(\d+\s?\$(?:\d+)?)?\s?[bcdefgosuxEFGX]!',
+                            '!%\s?(\d+\s?\$(?:\d+)?)?\s?[bcdefgosux]!i',
                             function( $m ) {
                                 return str_replace( ' ', '', $m[0] );
+                            },
+                            $translation
+                        );
+
+                        // Check case of format specifer. EFGX can be both upper or lower case.
+                        $translation = preg_replace_callback(
+                            '!%(\d+\$(?:\d+)?)?([bcdosu])!i',
+                            function( $m ) {
+                                return '%' . $m[1] . strtolower( $m[2] );
                             },
                             $translation