Changeset 10739

Timestamp:

03/03/2021 03:58:57 AM (3 years ago)

Author:

dd32

Message:

Translate: Allow Korean and chinese locales to skip emphasis/italic HTML tags in translations.

Follow up to [10731].
See #5643

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-custom-warnings/wporg-gp-custom-warnings.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-custom-warnings/wporg-gp-custom-warnings.php

@@ -121 +121 @@
      *  - The value of translatable/url attributes is excluded from the error message if it's not related to the issue at hand.
      *  - Tags are sorted, <em>One</em> <strong>Two</strong> can be translated as <strong>foo</strong> <em>bar</em> without generating warning.
-     *  - Japanese can remove `<em>` tags.
+     *  - East asian languages can remove emphasis/italic tags.
      *  - TODO: Tags are not validated to be nested correctly. GlotPress handles this by validating the ordering of the tags remained the same.
-     *  - TODO: Extend/abstract the locales which can remove certain tags.
      *
      * @param string    $original    The source string.
@@ -143 +142 @@
         }
 
-        // Allow Japanese to exclude <em>. TODO: Abstract this / extend it to all languages affected / extend to full list of tags.
+        // Allow certain laguages to exclude certain tags.
         if ( count( $original_parts ) > count( $translation_parts ) ) {
 
             $languages_without_italics = [
-                'ja',
-                // 'ko', 'zh', 'zh-hk', 'zh-cn', 'zh-sg', 'zh-tw' ??
+                'ja', 'ko', 'zh', 'zh-hk', 'zh-cn', 'zh-sg', 'zh-tw'
             ];