Changeset 10761 for sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/phpunit/tests/init.php

Timestamp:

03/04/2021 11:27:47 PM (5 years ago)

Author:

coffee2code

Message:

Handbooks, Unit tests: Minor refactors to prevent PHP errors when things aren't working as expected.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/phpunit/tests/init.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/phpunit/tests/init.php

@@ -44 +44 @@
     public function test_get_handbook_objects_default() {
         $handbooks = WPorg_Handbook_Init::get_handbook_objects();
+        $first_handbook = reset( $handbooks );
 
         $this->assertIsArray( $handbooks );
         $this->assertCount( 1, $handbooks );
-        $this->assertInstanceOf( 'WPorg_Handbook', $handbooks[0] );
-        $this->assertEquals( 'handbook', $handbooks[0]->post_type );
+        $this->assertInstanceOf( 'WPorg_Handbook', $first_handbook );
+        $this->assertEquals( 'handbook', $first_handbook->post_type );
     }
 
@@ -58 +59 @@
         $this->assertIsArray( $handbooks );
         $this->assertCount( 2, $handbooks );
-        $this->assertInstanceOf( 'WPorg_Handbook', $handbooks[0] );
-        $this->assertEquals( 'plugins-handbook', $handbooks[0]->post_type );
-        $this->assertInstanceOf( 'WPorg_Handbook', $handbooks[1] );
-        $this->assertEquals( 'themes-handbook', $handbooks[1]->post_type );
+
+        $first_handbook = reset( $handbooks );
+        $this->assertInstanceOf( 'WPorg_Handbook', $first_handbook );
+        $this->assertEquals( 'plugins-handbook', $first_handbook->post_type );
+
+        $second_handbook = next( $handbooks );
+        $this->assertInstanceOf( 'WPorg_Handbook', $second_handbook );
+        $this->assertEquals( 'themes-handbook', $second_handbook->post_type );
     }
 
@@ -75 +80 @@
         reinit_handbooks( [ 'plugins', 'themes' ], 'post_types' );
 
-        $this->assertEquals( ['plugins', 'themes'], WPorg_Handbook_Init::get_post_types() );
+        // Note: The automatic appending of '-handbook' is for back-compat.
+        $this->assertEquals( ['plugins-handbook', 'themes-handbook'], WPorg_Handbook_Init::get_post_types() );
     }