Changeset 10781

Timestamp:

03/05/2021 12:50:03 AM (4 years ago)

Author:

coffee2code

Message:

Handbooks, Explicitly remove '-handbook' from post types rather than assuming it's the last nine characters.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc

Files:

• handbook.php (modified) (3 diffs)
• widgets.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/handbook.php

@@ -135 +135 @@
             // If no name defined yet, try handbook post type if not standard.
             if ( ! $name && ( 'handbook' !== $post_type ) ) {
-                $name = ucfirst( substr( $post_type, 0, -9 ) );
+                $name = ucfirst( str_replace( '-handbook', '', $post_type ) );
             }
 
@@ -285 +285 @@
         $label = ( 'handbook' === $this->post_type ) ?
             __( 'Handbook name', 'wporg' ) :
-            sprintf( __( 'Handbook name (%s)', 'wporg' ), substr( $this->post_type, 0, -9 ) );
+            sprintf( __( 'Handbook name (%s)', 'wporg' ), str_replace( '-handbook', '', $this->post_type ) );
 
         add_settings_field(
@@ -525 +525 @@
             $page = get_page_by_path( $this->post_type, OBJECT, $this->post_type );
             if ( ! $page ) {
-                $slug = substr( $this->post_type, 0, -9 );
+                $slug = str_replace( '-handbook', '', $this->post_type );
                 $page = get_page_by_path( $slug, OBJECT, $this->post_type );
             }

sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/widgets.php

@@ -95 +95 @@
         $page = get_page_by_path( $post_type, OBJECT, $post_type );
         if ( ! $page ) {
-            $slug = substr( $post_type, 0, -9 );
+            $slug = str_replace( '-handbook', '', $post_type );
             $page = get_page_by_path( $slug, OBJECT, $post_type );
         }