Changeset 10796 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-readme-validator.php

Timestamp:

03/09/2021 12:38:15 AM (5 years ago)

Author:

dd32

Message:

Plugin Directory: Readme Validator: Allow passing the readme URL through a GET parameter to make linking to readme examples easier.

See #2538.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-readme-validator.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-readme-validator.php

@@ -14 +14 @@
                 <div class="wrap">
                         <?php
-                        if ( $_POST ) {
+                        if ( $_REQUEST ) {
                                 self::validate_readme();
                         }
 
-                        $readme_url      = $_POST['readme_url'] ?? '';
+                        $readme_url      = $_REQUEST['readme'] ?? '';
                         $readme_contents = $_POST['readme_contents'] ?? '';
                         $readme_contents = base64_decode( wp_unslash( $readme_contents ) );
                         ?>
 
-                        <form method="post" action="">
+                        <form method="get" action="">
                                 <p>
-                                        <input type="text" name="readme_url" size="70" placeholder="https://" value="<?php echo esc_attr( $readme_url ); ?>" />
+                                        <input type="text" name="readme" size="70" placeholder="https://" value="<?php echo esc_attr( $readme_url ); ?>" />
                                         <input type="submit" class="button button-secondary" value="<?php esc_attr_e( 'Validate!', 'wporg-plugins' ); ?>" />
                                 </p>
@@ -33 +33 @@
                                 <textarea rows="20" cols="100" name="readme_visible" placeholder="=== Plugin Name ==="><?php echo esc_textarea( $readme_contents ); ?></textarea>
                                 <form id="readme-data" method="post" action="">
+                                        <input type="hidden" name="readme" value="" />
                                         <textarea class="screen-reader-text" rows="20" cols="100" name="readme_contents"><?php echo esc_textarea( $readme_contents ); ?></textarea>
                                 <p><input type="submit" class="button button-secondary" value="<?php esc_attr_e( 'Validate!', 'wporg-plugins' ); ?>" /></p>
@@ -58 +59 @@
          */
         protected static function validate_readme() {
-                if ( ! empty( $_POST['readme_url'] ) ) {
-                        $errors = Validator::instance()->validate_url( wp_unslash( $_POST['readme_url'] ) );
+                if ( ! empty( $_REQUEST['readme'] ) ) {
+                        $errors = Validator::instance()->validate_url( wp_unslash( $_REQUEST['readme'] ) );
 
                 } elseif ( ! empty( $_POST['readme_contents'] ) ) {