Changeset 10819

Timestamp:

03/15/2021 05:36:06 AM (5 years ago)

Author:

dd32

Message:

Support Forum: Use the slug from the Plugin/Theme object directly rather than the user-supplied slug.

This fixes reviews being made against the incorrect slug such as Example-Plugin rather than example-plugin which then fail to be returned in some situations.

See ​https://wordpress.slack.com/archives/C02RQC6RW/p1615785038495300 for an example.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc

Files:

• class-plugin-directory-compat.php (modified) (1 diff)
• class-theme-directory-compat.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-plugin-directory-compat.php

@@ -97 +97 @@
         }
 
-        $this->slug         = $slug;
+        $this->slug         = $plugin->post_name;
         $this->plugin       = $plugin;
         $this->authors      = $this->get_authors( $slug );

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-theme-directory-compat.php

@@ -97 +97 @@
         }
 
-        $this->slug         = $slug;
+        $this->slug         = $theme->post_name;
         $this->theme        = $theme;
         $this->authors      = $this->get_authors( $slug );