Changeset 10821

Timestamp:

03/16/2021 02:05:35 AM (4 years ago)

Author:

dd32

Message:

Support Forums: Also Viewing: Code / warning cleanups.

• Don't use deprecated jQuery functionality
• Properly clear the caches when expiring some 'viewing' notifications.
• Use a per-site, rather than per-network option for creating the table. Only affects networks with multiple sites using it.
• Mark the option in the user profile as translatable.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-bbp-also-viewing

Files:

• wporg-bbp-also-viewing.js (modified) (3 diffs)
• wporg-bbp-also-viewing.php (modified) (4 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-bbp-also-viewing/wporg-bbp-also-viewing.js

@@ -20 +20 @@
     }
 
-    jQuery( document ).on( 'ready', function($) {
+    jQuery( document ).ready( function() {
         maybeDisplay();
 
@@ -74 +74 @@
 
     // Pin the banner to the top of the screen when scrolling.
-    jQuery(window).scroll( function() {
+    jQuery(window).on( 'scroll', function() {
         if ( ! banner ) {
             return;
@@ -161 +161 @@
         } );
     } );
-
-    // DEBUG. Expose the functions for testing.
-    window.alsoViewing = {
-        refreshViewers: refreshViewers,
-        updateState: updateState,
-        transmitIsTyping: transmitIsTyping,
-        transmitNoLongerTyping: transmitNoLongerTyping,
-    }
 })();

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-bbp-also-viewing/wporg-bbp-also-viewing.php

@@ -200 +200 @@
         checked( enabled( $user_id ), true, false ),
         sprintf(
-            'Enable the <a href="%s">Also Viewing</a> feature.', // TODO: Translate once text is figured out __( , 'wporg-forums' ),
+            __( 'Enable the <a href="%s">Also Viewing</a> feature.', 'wporg-forums' ),
             'https://make.wordpress.org/support/handbook/appendix/helpful-tools/#avoiding-overlapping-replies'
         )
@@ -368 +368 @@
 
     foreach ( $pages as $p ) {
-        wp_cache_delete( $page, CACHE_GROUP );
+        wp_cache_delete( $p, CACHE_GROUP );
     }
 }
@@ -442 +442 @@
     global $wpdb;
 
-    if ( get_site_option( 'also-viewing' ) ) {
+    if ( get_option( 'also-viewing' ) ) {
         return;
     }
@@ -462 +462 @@
     );
 
-    update_site_option( 'also-viewing', true );
-}
+    update_option( 'also-viewing', true );
+}