Changeset 10828

Timestamp:

03/18/2021 03:11:43 AM (4 years ago)

Author:

dd32

Message:

Slack: Update the /subgroup command, take three.

Shift the response to the /subgroup command to async ephemeral responses. Unfortunately the replace_original flag seems not to work.
Slack requires that the response to the slash command be a 200 response within 3000ms, unfortunately due to the migration to their newer API's this API now often takes longer than that.

See [10823] and [10824].

File:

• sites/trunk/api.wordpress.org/public_html/dotorg/slack/subgroup.php (modified) (8 diffs)

sites/trunk/api.wordpress.org/public_html/dotorg/slack/subgroup.php

@@ -21 +21 @@
 }
 
+// WARNING: Can only be called FIVE times per request.
+function update_text( $text ) {
+    if ( empty( $_POST['response_url'] ) ) {
+        die( "response_url missing." );
+    }
+
+    $payload = [
+        'response_type'    => 'ephemeral',
+        'replace_original' => 'true', // Doesn't work.
+        'text'             => $text,
+    ];
+
+    $context = stream_context_create( [ 'http' => [
+        'method'  => 'POST',
+        'header'  => 'Content-Type: application/json',
+        'content' => json_encode( $payload ),
+    ] ] );
+
+    file_get_contents( $_POST['response_url'], false, $context );
+}
+
+function die_text( $text ) {
+    update_text( $text );
+    die();
+}
+
 // Confirm it came from Slack.
 if ( $_POST['token'] !== WEBHOOK_TOKEN ) {
     die( "Invalid Token" );
 }
+
+// This API needs to return a successful 200 ASAP, within 3 seconds, and most of the API calls below will take longer than.
+header( 'HTTP/1.0 200 OK' );
+flush();
+if ( function_exists( 'fastcgi_finish_request' ) ) {
+    fastcgi_finish_request();
+}
+
+update_text( 'Please wait.. This could take a moment..' );
 
 $current_group_id = $_POST['channel_id'];
@@ -52 +87 @@
 // Sorry - @wordpressdotorg isn't in this group.
 if ( empty( $found ) ) {
-    die( "@wordpressdotorg isn't here." );
+    die_text( "@wordpressdotorg isn't here." );
 }
 
 // Can't call this from a subgroup.
 if ( $pos = strpos( $group['name'], '-' ) ) {
-    die( sprintf( 'Call this from the main `%s` group.', substr( $group['name'], 0, $pos ) ) );
+    die_text( sprintf( 'Call this from the main `%s` group.', substr( $group['name'], 0, $pos ) ) );
 }
 
@@ -72 +107 @@
 // Ensure the calling user is in the main group.
 if ( ! in_array( $_POST['user_id'], $members, true ) ) {
-    die;
+    die_text( 'Unauthorized' );
 }
 
@@ -81 +116 @@
     case 'create':
         if ( 0 !== strpos( $subcommand, $group['name'] . '-' ) ) {
-            die( "Must create a group that starts with `{$group['name']}-`." );
+            die_text( "Must create a group that starts with `{$group['name']}-`." );
         }
 
@@ -93 +128 @@
         );
         if ( empty( $new_group['ok'] ) ) {
-            die( "Group creation failed. Does it already exist?" );
+            die_text( "Group creation failed. Does it already exist?" );
         }
 
@@ -122 +157 @@
         );
 
-        die( sprintf( "Group %s created.", $new_group['group']['name'] ) );
+        die_text( sprintf( "Group %s created.", $new_group['group']['name'] ) );
 
     case 'invite':
@@ -137 +172 @@
                 );
 
-                die( "Invited to {$group['name']}." );
+                die_text( "Invited to {$group['name']}." );
             }
         }
 
-        die( "$subcommand group not found." );
+        die_text( "$subcommand group not found." );
 
     case 'list':
@@ -167 +202 @@
 
         if ( $groups_to_add ) {
-            echo "You may join any of these groups:\n -- `" . implode( "`\n -- `", $groups_to_add ) . "`\n\n\n";
+            $text = "You may join any of these groups:\n -- `" . implode( "`\n -- `", $groups_to_add ) . "`\n\n\n";
         } else {
-            echo "You are in all {$parent_group['name']} subgroups that the @wordpressdotorg user knows about.\n\n";
-        }
-
-        die( "*Help:*\n`/subgroup list` - display this message\n`/subgroup join {name}` - join a subgroup\n`/subgroup create {name}` - create a subgroup" );
-}
-
+            $text = "You are in all {$parent_group['name']} subgroups that the @wordpressdotorg user knows about.\n\n";
+        }
+
+        die_text( $text . "*Help:*\n`/subgroup list` - display this message\n`/subgroup join {name}` - join a subgroup\n`/subgroup create {name}` - create a subgroup" );
+}
+