Changeset 10832

Timestamp:

03/18/2021 08:33:16 PM (5 years ago)

Author:

coffee2code

Message:

Markdown Importer: Ensure 'a' is an allowed tag within imported posts.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-markdown/inc/class-importer.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-markdown/inc/class-importer.php

@@ -480 +480 @@
         $html = apply_filters( 'wporg_markdown_after_transform', $html, $this->get_post_type() );
 
+        add_filter( 'wp_kses_allowed_html', [ $this, 'wp_kses_allow_links' ], 10, 2 );
+
         $post_data = array(
             'ID'           => $post_id,
@@ -486 +488 @@
         );
 
+        remove_filter( 'wp_kses_allowed_html', [ $this, 'wp_kses_allow_links' ], 10 );
+
         $fields_from_manifest = $this->update_post_from_manifest( $post_id, $title, false );
         if ( $fields_from_manifest ) {
@@ -497 +501 @@
 
         return true;
+    }
+
+    /**
+     * Ensures that the 'a' tag and certain of its attributes are allowed in
+     * posts if not already.
+     *
+     * Supported 'a' attributes are those defined for `$allowedposttags` by default.
+     *
+     * This is necessary since the 'a' tag is being removed somewhere along the way.
+     *
+     * @param array[]|string $allowed_tags Allowed HTML tags and their attributes
+     *                                     or the context to judge allowed tags by.
+     * @param string         $context      Context name.
+     * @return array[]|string
+     */
+    public function wp_kses_allow_links( $allowed_tags, $context ) {
+        if ( 'post' === $context && is_array( $allowed_tags ) && empty( $allowed_tags[ 'a' ] ) ) {
+            $allowed_tags['a'] = [
+                'href'     => true,
+                'rel'      => true,
+                'rev'      => true,
+                'name'     => true,
+                'target'   => true,
+                'download' => [
+                        'valueless' => 'y',
+                ],
+            ];
+        }
+
+        return $allowed_tags;
     }