Changeset 10872

Timestamp:

04/06/2021 06:33:45 AM (5 years ago)

Author:

dd32

Message:

Theme Directory: Ensure that theme slugs are always ascii for best compatibility by converting any accented characters to non-accented and removing any that cannot be

There are no current published themes that have accented characters in their slugs.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php

@@ -207 +207 @@
 
         // Let's check some theme headers, shall we?
-
-        if ( ! $this->theme_name = $this->theme->get( 'Name' ) ) {
+        $this->theme_name = $this->theme->get( 'Name' );
+
+        // Determine the theme slug (ascii only for compatibility) based on the name of the theme in the stylesheet
+        $this->theme_slug = remove_accents( $this->theme_name );
+        $this->theme_slug = preg_replace( '/%[a-f0-9]{2}/i', '', $this->theme_slug );
+        $this->theme_slug = sanitize_title_with_dashes( $this->theme_slug );
+
+        if ( ! $this->theme_name || ! $this->theme_slug ) {
             $error = __( 'The theme has no name.', 'wporg-themes' ) . ' ';
 
@@ -220 +226 @@
             return $error;
         }
-
-        // determine the theme slug based on the name of the theme in the stylesheet
-        $this->theme_slug = sanitize_title_with_dashes( $this->theme_name );
 
         // Do not allow themes with WordPress and Theme in the theme name.