Changeset 10917

Timestamp:

04/21/2021 05:26:06 AM (5 years ago)

Author:

dd32

Message:

Support: Don't respond with a 400 error when performing actions on spammed topics.

bbPress incorectly generates a link with p=1234/ (note the trailing slash) which triggers the blocking code.

File:

• sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/wporg-bad-request.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/wporg-bad-request.php

@@ -74 +74 @@
 
             if ( isset( $must_be_num[ $field ] ) && ! empty( $vars[ $field ] ) && ! is_numeric( $vars[ $field ] ) ) {
+
+                // Allow the `p` variable to contain `p=12345/`: https://bbpress.trac.wordpress.org/ticket/3424
+                if ( 'p' === $field && ( intval( $vars[ $field ] ) . '/' === $vars[ $field ] ) ) {
+                    continue;
+                }
+
                 die_bad_request( "non-numeric $field in $ref" );
             }